fix: fixed crash in CosmovisorUpgradesGenerator

pkg/generators/cosmovisor_upgrades_generator.go

@@ -39,6 +39,10 @@ func (g *CosmovisorUpgradesGenerator) Get(state fetchers.State) []metrics.Metric
 		panic("expected the state entry to be types.UpgradesPresent")
 	}
 
+	if upgradePlan == nil {
+		return []metrics.MetricInfo{}
+	}
+
 	// From cosmovisor docs:
 	// The name variable in upgrades/<name> is the lowercase URI-encoded name
 	// of the upgrade as specified in the upgrade module plan.

pkg/generators/cosmovisor_upgrades_generator_test.go

@@ -57,8 +57,7 @@ func TestCosmovisorUpgradesGeneratorEmptyInvalidUpgrades(t *testing.T) {
 	}
 
 	generator := NewCosmovisorUpgradesGenerator()
-	metrics := generator.Get(state)
-	assert.Empty(t, metrics)
+	generator.Get(state)
 }
 
 func TestCosmovisorUpgradesGeneratorEmptyInvalidCosmovisorUpgrades(t *testing.T) {
@@ -75,6 +74,20 @@ func TestCosmovisorUpgradesGeneratorEmptyInvalidCosmovisorUpgrades(t *testing.T)
 		constants.FetcherNameCosmovisorUpgrades: 3,
 	}
 
+	generator := NewCosmovisorUpgradesGenerator()
+	generator.Get(state)
+}
+
+func TestCosmovisorUpgradesGeneratorEmptyUpgradePlan(t *testing.T) {
+	t.Parallel()
+
+	var upgradePlan *upgradeTypes.Plan
+
+	state := fetchers.State{
+		constants.FetcherNameUpgrades:           upgradePlan,
+		constants.FetcherNameCosmovisorUpgrades: types.UpgradesPresent{},
+	}
+
 	generator := NewCosmovisorUpgradesGenerator()
 	metrics := generator.Get(state)
 	assert.Empty(t, metrics)