Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Useful skills and perks #187

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

ahmed007boss
Copy link

@ahmed007boss ahmed007boss commented Apr 17, 2024

Improve the impact of perks when the feature is turned on from the settings, enabling perks to increase in power as related character skill level improves. Also, expand the range of roles for each skill to offer more flexibility.

Example:
image

Steward

  • Perks (21/21)
  • Skills Effects (3/3)
  • Localization
  • Testing

Medicine (in progress)

  • Perks (2/21)
  • Skills Effects
  • Localization
  • Testing

Leadership

  • Perks (0/21)
  • Skills Effects
  • Localization
  • Testing

OneHanded

  • Perks (0/21)
  • Skills Effects
  • Localization
  • Testing

TwoHanded

  • Perks (0/18)
  • Skills Effects
  • Localization
  • Testing

Polearm

  • Perks (0/21)
  • Skills Effects
  • Localization
  • Testing

Bow

  • Perks (0/21)
  • Skills Effects
  • Localization
  • Testing

Crossbow

  • Perks (0/21)
  • Skills Effects
  • Localization
  • Testing

Throwing

  • Perks (0/21)
  • Skills Effects
  • Localization
  • Testing

Riding

  • Perks (0/20)
  • Skills Effects
  • Localization
  • Testing

Athletics

  • Perks (0/21)
  • Skills Effects
  • Localization
  • Testing

Crafting

  • Perks (0/20)
  • Skills Effects
  • Localization
  • Testing

Tactics

  • Perks (0/21)
  • Skills Effects
  • Localization
  • Testing

Scouting

  • Perks (0/21)
  • Skills Effects
  • Localization
  • Testing

Roguery

  • Perks (0/21)
  • Skills Effects
  • Localization
  • Testing

Charm

  • Perks (0/20)
  • Skills Effects
  • Localization
  • Testing

Trade

  • Perks (0/21)
  • Skills Effects
  • Localization
  • Testing

Engineering

  • Perks (0/21)
  • Skills Effects
  • Localization
  • Testing

Scholarship

  • Perks (0/13)
  • Skills Effects
  • Localization
  • Testing

Theology

  • Perks (0/6)
  • Skills Effects
  • Localization
  • Testing

Lordship

  • Perks (0/8)
  • Skills Effects
  • Localization
  • Testing

@ahmed007boss ahmed007boss marked this pull request as draft April 17, 2024 23:21
- fix bug where PerkBonus can be infinity
- fix exception when GetAllPartyHeros mobileParty parameter is null
- add better Steward Giving Hands perk
- make item quality side by side with tier affect gained exp from item donation
- fix few bugs
- add proper BKConstructionModel.GetBoostAmount Perk Effect
- family members now include grandchildren and nephew and nieces
- Steward Relocation and AidCorps perks
- make WarriorsDiet apply on either leader or quartermaster
- Steward Gourmet and Sound Reserves perks
- filter perks calculation with only active heros
- restructure perk data
- add steward skill effect
- add ForcedLabor and Contractors perks
- add MasterOfPlanning,MasterOfWarcraft and PriceOfLoyalty traits
- add Medicine Perks data
- add SelfMedication Perk
- add bonus from court and royal court
- add TriageTent  and WalkItOff perks
- fix few bugs
- fix few perk related texts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant