Skip to content

Commit

Permalink
Fix broken image links
Browse files Browse the repository at this point in the history
  • Loading branch information
GeckoEidechse committed Sep 30, 2024
1 parent 9c3ee01 commit dcc3249
Show file tree
Hide file tree
Showing 9 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions docs/Wiki/development/reviewing.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@ It's not necessary to do both when reviewing as long as you mention what you did

For code review head to the _"Files changed"_ section of the PR.

![](../.gitbook/assets/review1.png)
![](/_static/wiki/review1.png)

From there you can select the line(s) you want to leave a comment on.

![](../.gitbook/assets/review2.PNG)
![](/_static/wiki/review2.PNG)

Type in your comment and click on _"Start a review"_.

![](../.gitbook/assets/review3.png)
![](/_static/wiki/review3.png)

Note that this will **NOT** post your comment immediately! Add any remaining comments to other lines of code, then head to the _Finishing up_ section of this wiki page to see how to post your code review.

Expand All @@ -47,7 +47,7 @@ The TL;DR is to test the aspect that has been changed.

After you performed the testing and/or code review leave a final comment by clicking on _"Finish your review"_ on the top right of the _"Files changed"_ page of the PR.

![](../.gitbook/assets/review4.png)
![](/_static/wiki/review4.png)

In your final comment make sure to mention what you did, e.g. which aspects of the change you tested for or what you considered during code review (formatting, edge cases, ...). The more detailed this part is the easier it is for other reviewers to tell which aspects they can skip during reviewing to speed up the process.

Expand Down
4 changes: 2 additions & 2 deletions docs/Wiki/development/testing.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,11 @@ Alternatively, compiling the PR'd code from source is also an option. For this,

Click on the source branch of the PR

![](../.gitbook/assets/download-mods-pr1.png)
![](/_static/wiki/download-mods-pr1.png)

Click on _"Code"_ and then on _"Download ZIP"_

![](../.gitbook/assets/download-mods-pr2.png)
![](/_static/wiki/download-mods-pr2.png)

From there copy over all the `Northstar.XXXXX` folders into your mods folder in your Titanfall2 install the same way you would manually install mods.

Expand Down
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes

0 comments on commit dcc3249

Please sign in to comment.