fix: Add vanilla compatibility for setplaylistvar byte-patch #687
Conversation
|
+1 lgtm |
There was a problem hiding this comment.
This pr works as intended, and solves the issue I've been trying to with Northstar (where vanilla private match settings wont apply).
No idea if it introduces any kind of security concern, someone else can confirm (e.g. does this allow vanilla users to change these variables when they aren't meant to be able to via console)
However, in contrary to your other prs this one does only work if vanilla and northstar are split. I am personally all for them being split still, but it's something to consider if you really wish to make them compatible
I just think the comment should be changed to describe what's happening better
Co-authored-by: Cyn <[email protected]>
I'm confused, you mean this (somehow) breaks behaviour in Northstar? |
| @@ -121,5 +122,7 @@ ON_DLL_LOAD_RELIESON("engine.dll", PlaylistHooks, (ConCommand, ConVar), (CModule | |||
| module.Offset(0x18ED8D).Patch("C3"); | |||
|
|
|||
| // patch to allow setplaylistvaroverride to be called before map init on dedicated and private match launched through the game | |||
| module.Offset(0x18ED17).NOP(6); | |||
| // only run on non-vanilla as this patch makes users unable to change private match settings on vanilla | |||
| if (!g_pVanillaCompatibility->GetVanillaCompatibility()) | |||
There was a problem hiding this comment.
would rather this byte patch was replaced with a function hook, so that in the case where vanilla compatibility becomes toggleable at runtime this will behave properly.
This PR fixes #623 by adding a vanilla compatibility check for some NOPs in playlist.cpp