Get lobby announcement from Atlas #699
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASpoonPlaysGames
commented
Sep 5, 2023
Comment on lines
+816
to
+819
| #if HAS_NORTHSTAR_CUSTOM | ||
| // relies on script HTTP which is in Northstar.Custom | ||
| thread GetAtlasAnnouncement_Threaded() | ||
| #endif // HAS_NORTHSTAR_CUSTOM |
There was a problem hiding this comment.
This was done to avoid having to override ui/_menus.nut in Northstar.Custom as well.
I could have done the HTTP stuff in Launcher, but that then splits this feature into 3 PRs :/
Unfortunately this does mean that clients who have Northstar.Custom disabled will not see the announcements. This makes up a tiny proportion of the playerbase, so personally I'm not too concerned.
github-actions
bot
added
the
merge conflicts
github-actions
bot
removed
the
merge conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking as a draft because this relies on a new Atlas endpoint. (R2Northstar/Atlas#38)