Add functionality to PlayerAssist callback #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASpoonPlaysGames
added
needs testing
|
Very weird whitespace stuff going on here lol Will properly review once I can tell what actually changed |
ASpoonPlaysGames
added
the
waiting on changes by author
github-actions
bot
added
the
merge conflicts
|
Any updates on this to solve conflicts? There's some other stuff that requires changing as well before merging. |
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
removed
the
merge conflicts
GeckoEidechse
force-pushed
the
assist-callback
branch
from
23aa020
to
f824608
Compare
|
Aight, I reverted all the unrelated whitespace changes via f824608 to clean up the diff (omfg we desperately need a Squirrel formatter so this doesn't keep happening and doesn't need to be done by hand...) |
GeckoEidechse
removed
the
waiting on changes by author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a function to the player killed callback that is just a copy paste of how we handle assists everywhere else
yes this PR is untested :>