[FD]Fix bug and some features in vanilla #730

zxcPandora · 2023-10-02T15:25:29Z

[Features]

Timeout now will work in the correct way
Only record the time when player is playing
Avoid crash due to animation error when player destroyed
Avoid crash while player accidental death in dropship
Avoid crash due to invalid weapon for mortar spectres (Temporary fix,it need a better way)
Check sniper titan's enemy is valid(Although the probability of triggering is very low)
Try fix cloaked drone bug(What Bug: Wave will never end due to hidden cloaked drone )
fix for all can't enter next wave bug(thx @Zanieon )
Make score system work,include:
(1) Players on the scoreboard can be sorted correctly
(2) Display assault score and defense score after wave end
(3) Display total score on the scoreboard
Reaper hot drop warning
Add missing data collection:turret repair
Check player valid before score set AddToPlayerGameStat
Check entity valid before use EmitSoundOnEntityOnlyToPlayer to play sound
make sure trigger work after all entities did load
fix a bug that allow player loop pick up turret
Avoid server error:player while parented when playing cam
Avoid malicious scoring
Avoid harvester actually got destroy by use AddEntityCallback_OnPostDamaged
Avoid script error due to invalid rodeo target
Avoid server crash due to all players exited

if player didn't kill the cloaked drone. Sometime it will cause a bug that wave will never end after player kill other npcs. And player will never find out the cloaked drone. (This bug also exist in vanilla,most of time triggered this bug in map:mp_angel_city )

Hope someone do a better way to fix this bug.It's a temporary fix

This reverts commit 15de172.

Check entity in runWave to prevent crash

1.fix a bug that allow player loop pick up turret 2.`IsValid()` check no needed due to `EndSignal()` check

temporary fix for all can't enter next wave bug(By delete game auto revive turret)

1.Check sniper titan's enemy is valid(Although the probability of triggering is very low) 2.Match will lose after all player exit 3.More accurate health check way for harvester

@Zanieon

turret bug fixed by @Zanieon

…into bug_fix

ASpoonPlaysGames · 2023-10-07T10:15:16Z

Im going to be honest I very much doubt that this will get merged without the individual changes being split up into different PRs

zxcPandora · 2023-10-07T14:25:56Z

Im going to be honest I very much doubt that this will get merged without the individual changes being split up into different PRs

>_<，think you're right.
I should do it in a few days

…into bug_fix

zxcPandora and others added 30 commits February 8, 2023 13:24

gamestate check

2a08858

timeout will now work in the correct way

b210116

try fix animation error

886d23b

clear Invulnerable

17fae0e

do entity check after wait

f668c19

avoid crash while player accidental death in dropship

9634c5f

let player immediately respawn when pass over 4 player

499b3c0

Update _gamemode_fd.nut

b45f992

double check for player

5a916c9

Temporary fix for invalid weapon

a43160c

fix cloaked drone bug

0514c14

if player didn't kill the cloaked drone. Sometime it will cause a bug that wave will never end after player kill other npcs. And player will never find out the cloaked drone. (This bug also exist in vanilla,most of time triggered this bug in map:mp_angel_city )

Avoid repeated kill

a473144

reuse check

6d6c3cf

Merge branch 'gamemode_fd' into bug_fix

718c4b6

Merge branch 'gamemode_fd' into bug_fix

959836c

Try fix:When ai count is 0,can't continue to next wave

fce883b

Hope someone do a better way to fix this bug.It's a temporary fix

make score system work

6e1c55f

I hate nesting

c53d677

use another way to fix cloaked drones

abc377c

Update _gamemode_fd.nut

0df6ebc

Update _gamemode_fd.nut

fcd3bc1

Reaper hot drop warning

44d84c6

add defense score for arc trap and sonar

234c5ef

avoid server crash due to all players exiting

6673a58

add mising data collect

4146db1

Temporary fix:try again

6515be8

check player is invalid

b555f70

make sure it work after entity creation

15de172

Revert "make sure it work after entity creation"

4e093ed

This reverts commit 15de172.

make sure all entities did load

3078ab5

SamLam140330 and others added 19 commits March 10, 2023 03:30

Check entity in runWave

d17b175

Change to continue instead of return false

9734e76

Merge pull request #1 from SamLam140330/bug_fix

292407f

Check entity in runWave to prevent crash

fix a bug that allow player loop pick up turret

e92e861

1.fix a bug that allow player loop pick up turret 2.`IsValid()` check no needed due to `EndSignal()` check

check before play sound

7f2b3f1

fix bug when wave end and game auto revive turret

f72589f

avoid script erroe

f072318

avoid script error and temporary fix for can't enter next wave bug

1657209

temporary fix for all can't enter next wave bug(By delete game auto revive turret)

Avoid malicious scoring

9cd92cb

avoid script error due to invalid rodeo target

71f6059

avoid server crash

8d7e9f2

1.Check sniper titan's enemy is valid(Although the probability of triggering is very low) 2.Match will lose after all player exit 3.More accurate health check way for harvester

avoid harvester got destroy

4174ad2

cancel store change

804b2bf

Update sh_boost_store.gnut

42716d1

turret bug fixed by @Zanieon

a7e9709

turret bug fixed by @Zanieon

Update sh_boost_store.gnut

17c9361

Merge branch 'gamemode_fd' into bug_fix

7f3c792

Update _ai_turret.gnut

65a2864

Merge branch 'bug_fix' of https://github.com/zxcPandora/NorthstarMods …

5172588

…into bug_fix

ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Oct 7, 2023

Merge branch 'gamemode_fd' into bug_fix

adb71a0

ASpoonPlaysGames added waiting on changes by author Waiting on PR author to implement the suggested changes and removed needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Oct 21, 2023

GeckoEidechse and others added 3 commits January 4, 2024 03:01

Merge branch 'gamemode_fd' into bug_fix

04b6ae0

fix titanloadout invalid issue

539053f

Merge branch 'bug_fix' of https://github.com/zxcPandora/NorthstarMods …

18995b0

…into bug_fix

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FD]Fix bug and some features in vanilla #730

[FD]Fix bug and some features in vanilla #730

zxcPandora commented Oct 2, 2023 •

edited

Loading

ASpoonPlaysGames commented Oct 7, 2023

zxcPandora commented Oct 7, 2023 •

edited by GeckoEidechse

Loading

[FD]Fix bug and some features in vanilla #730

Are you sure you want to change the base?

[FD]Fix bug and some features in vanilla #730

Conversation

zxcPandora commented Oct 2, 2023 • edited Loading

ASpoonPlaysGames commented Oct 7, 2023

zxcPandora commented Oct 7, 2023 • edited by GeckoEidechse Loading

zxcPandora commented Oct 2, 2023 •

edited

Loading

zxcPandora commented Oct 7, 2023 •

edited by GeckoEidechse

Loading