Fix Discord presence crashing on Campaign #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
needs testing
GeckoEidechse
approved these changes
Sep 13, 2024
GeckoEidechse
added
almost ready to merge
GeckoEidechse
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Not super happy with multiple changes in one file but I also want this fixes so I'm letting it slide...
Otherwise changes make sense.
Also just noticed that #869 introduced mixed whitespace indentation but kinda too late now. Oh well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small oversight by my part when i did the feature improvements to the Discord RPC plugin, this should fix the issue when playing Campaign or Coop.
EDIT: I took the liberty to also use the PR to fix some other minor issues in regards to report how many players are currently playing the server and the actual max playerslots the server have in total.