Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for configuring a base URL #65

Merged
merged 7 commits into from
Feb 18, 2024
Merged

Allow for configuring a base URL #65

merged 7 commits into from
Feb 18, 2024

Conversation

jamiefeiss
Copy link
Collaborator

Can configure Prez UI to have a base URL other than /, both in a static site or Docker deployment. This can be set with the VITE_BASE_URL environment variable.

Thanks @avillar for your updates.

@jamiefeiss jamiefeiss requested a review from avillar June 2, 2023 04:42
edmondchuc
edmondchuc previously approved these changes Jul 5, 2023
avillar
avillar previously approved these changes Aug 4, 2023
@avillar
Copy link
Collaborator

avillar commented Sep 5, 2023

Does this functionality already exist in the main branch (i.e., is this PR still relevant)?

@jamiefeiss
Copy link
Collaborator Author

@avillar the main branch doesn't have this functionality yet. I'll get this branch up to date soon so we can merge this PR.

@jamiefeiss jamiefeiss marked this pull request as draft December 18, 2023 06:08
@jamiefeiss jamiefeiss dismissed stale reviews from avillar and edmondchuc via 9030727 February 7, 2024 07:14
@jamiefeiss jamiefeiss marked this pull request as ready for review February 7, 2024 07:30
@jamiefeiss
Copy link
Collaborator Author

This fix now works again. Sorry for the delay in getting this fixed.

I think it was the upgrade to the next Vite version that broke this before.
(the built index.js file naming convention changed from index.*.js to index-*.js)

@jamiefeiss jamiefeiss merged commit 69a3b44 into main Feb 18, 2024
1 check passed
@jamiefeiss jamiefeiss deleted the feature/base-url-fix branch February 18, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants