Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Start trace printing at index 0; Make EXAMPLE_DIRS in Makefile rewritable; Use COMPARSE_HOME environment variable in .fst.config.json file #83

Merged
merged 1 commit into from
Oct 30, 2024
Merged

feat: Start trace printing at index 0; Make EXAMPLE_DIRS in Makefile rewritable; Use COMPARSE_HOME environment variable in .fst.config.json file #83

merged 1 commit into from
Oct 30, 2024

Conversation

fabian-hk
Copy link
Contributor

No description provided.

@fabian-hk
feat: Start trace printing at index 0; Make EXAMPLE_DIRS in Makefile …
d3285fc 
…rewritable; Use COMPARSE_HOME in .fst.config.json file
@fabian-hk fabian-hk requested a review from TWal October 30, 2024 09:02
@fabian-hk fabian-hk requested a review from a team as a code owner October 30, 2024 09:02
@fabian-hk fabian-hk requested a review from cwaldm October 30, 2024 12:46
cwaldm
cwaldm approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@cwaldm cwaldm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, changing the makefile is really useful for external example repos using the core DY* repo!
I also stumbled upon the different trace indices in the printed traces some time ago, in particularly for nonces. Great that this is also fixed now!

TWal
TWal approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@TWal TWal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@TWal TWal merged commit 20d5ae4 into main Oct 30, 2024
1 check passed
@TWal TWal deleted the feature/minor-improvements branch October 30, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TWal TWal TWal approved these changes

@cwaldm cwaldm cwaldm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabian-hk @TWal @cwaldm