sys/net/gnrc: implement sock_aux_timestamp for TX #15883
+134
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribu
added
Area: network
maribu
requested review from
cgundogan,
haukepetersen,
MrKevinWeiss and
PeterKietzmann
as code owners
maribu
force-pushed
the
tx_timestamp
branch
3 times, most recently
from
d447d03 to
192b89b
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions. |
stale
bot
added
the
State: stale
stale
bot
removed
the
State: stale
github-actions
bot
added
Area: build system
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions. |
stale
bot
added
the
State: stale
|
IIRC we have some form of confirm send now? |
stale
bot
removed
the
State: stale
|
Yes, this should indeed work, provided that a driver would actually use |
|
This needs a rebase. |
|
This was a hell of a rebase, but it seems to work: |
maribu
removed
State: waiting for other PR
benpicco
added
the
CI: ready for build
benpicco
reviewed
May 13, 2024
github-actions
bot
added
the
Platform: ARM
benpicco
reviewed
May 13, 2024
Provide a type for use in netdev_driver_t::confirm_send() to fetch TX info.
Add member `netdev_tx_info_t tx_info` to `gnrc_tx_sync_t` to allow fetching TX info. This is a natural fit, as for fetching TX info, one has to wait for the transmission to conclude.
Make use of gnrc_tx_sync to retrieve the TX timestamp, if provided by lower layers and module sock_aux_timestamp is used.
Added `gnrc_tx_sync_t *gnrc_pktsnip_search_type(gnrc_pktsnip_t *pkt)` to more conveniently access the TX sync data of a packet.
We need `gnrc_tx_sync` to wait for the transmission to complete to fetch auxiliary data from sending in the upper layers, as otherwise we have no clue when the data is actually valid. In addition, we need `netdev_tx_info_timestamp` to tell the netdevs to provide said timestamp.
benpicco
reviewed
Jun 6, 2024
| @@ -281,6 +281,32 @@ struct netdev_radio_rx_info { | |||
| uint8_t lqi; /**< LQI of a received frame */ | |||
| }; | |||
|
|
|||
| /** | |||
| * @name Flags indicating which fields in @ref netdev_tx_info_t | |||
There was a problem hiding this comment.
Suggested change
| * @name Flags indicating which fields in @ref netdev_tx_info_t | |
| * @brief Flags indicating which fields in @ref netdev_tx_info_t |
There was a problem hiding this comment.
For groups @name is correct. That group only has a single member as of now, but that may change in the future
There was a problem hiding this comment.
Doxygen does not like it though - or you need additional doc for that member
|
|
Indeed 😦. It also fails for me in
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
netdev_tx_info_t, which contains a timestamp if (pseudo-)modulenetdev_tx_info_timestampis usedgnrc_tx_sync_tto contain a membernetdev_tx_info_t tx_info, which can be used to transfer TX info up the stackgnrc_netifto pass the newtx_infomember ofgnrc_tx_sync_ttonetdev_driver_t::confirm_send()when modulegnrc_tx_syncis usedgnrc_sockto pass timestamp ingnrc_tx_sync_t::tx_infoup tosock_udp_send_aux()/sock_ip_send_aux(), which in turn are extended to pass this on to the userstm32_ethTesting procedure
make BOARD=nucleo-f767zi -C tests/sock_udp_aux flash termifconfig12345of the NucleoThe output should look like this
Issues/PRs references
Depends on and includes: