Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcoap: minor fixes and separate response #20696

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

gcoap: minor fixes and separate response #20696

wants to merge 3 commits into from
+380 −1

Conversation

fabian18
Copy link
Contributor

@fabian18 fabian18 commented May 25, 2024 •
edited
Loading

Contribution description

minor fixes in CoAP

  • stop retransmissions when empty ACK in nanocoap socket is received
  • API change: allow to send request from specified local endpoint
  • gcoap forward proxy: reply with same address as destination address in the request

feature

  • gcoap separate response (even confirmable)

This so far only exists for easier development.
PR should be split later.

Testing procedure

/separate resource in gcoap example

Issues/PRs references

@github-actions github-actions bot added Area: network Area: Networking Area: CoAP Area: Constrained Application Protocol implementations Area: sys Area: System Area: examples Area: Example Applications labels May 25, 2024
@fabian18 fabian18 mentioned this pull request May 27, 2024
Merged
@fabian18 fabian18 force-pushed the pr/coap_fixes_and_gcoap_sep_resp branch 3 times, most recently from c28df13 to d0424ea Compare May 28, 2024 14:27
@fabian18 fabian18 mentioned this pull request May 29, 2024
Merged
@fabian18 fabian18 force-pushed the pr/coap_fixes_and_gcoap_sep_resp branch 2 times, most recently from 6be3903 to 74f71e4 Compare June 11, 2024 09:05
@fabian18 fabian18 force-pushed the pr/coap_fixes_and_gcoap_sep_resp branch from 74f71e4 to 3b93554 Compare June 14, 2024 07:21
@fabian18 fabian18 force-pushed the pr/coap_fixes_and_gcoap_sep_resp branch from 3b93554 to 280ee9a Compare August 27, 2024 14:49
@fabian18 fabian18 marked this pull request as ready for review September 17, 2024 18:49
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 23, 2024
@benpicco benpicco requested review from chrysn and maribu October 23, 2024 15:51
@riot-ci
Copy link

riot-ci commented Oct 23, 2024

Murdock results

❌ FAILED

280ee9a examples/gcoap: add /separate resource

Success Failures Total Runtime
103 0 9217 34s

Artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

@chrysn chrysn Awaiting requested review from chrysn

@maribu maribu Awaiting requested review from maribu

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Area: CoAP Area: Constrained Application Protocol implementations Area: examples Area: Example Applications Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabian18 @riot-ci @benpicco