Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feather-nrf52840: add config for NeoPixel LED #21017

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Nov 21, 2024

Contribution description

Adds the NeoPixel LED config for the Adafruit nRF52840 Express (its the same as for the Sense).

Testing procedure

Flash, e.g., the examples/saul app to a feather-nrf52840. The on-board RGB-LED should be controllable by the app.

Issues/PRs references

Exposed while testing #20996.

@miri64 miri64 added the Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation label Nov 21, 2024
@miri64 miri64 requested review from maribu and mguetschow November 21, 2024 12:12
@github-actions github-actions bot added the Area: boards Area: Board ports label Nov 21, 2024
@maribu maribu enabled auto-merge November 21, 2024 12:15
@miri64 miri64 force-pushed the feather-nrf52840/enh/ws281x branch from bf5fcb6 to 5dd5400 Compare November 21, 2024 12:27
@mguetschow
Copy link
Contributor

Tested on BOARD=feather-nrf52840-sense, works like a charm!

@miri64
Copy link
Member Author

miri64 commented Nov 21, 2024

Tested on BOARD=feather-nrf52840-sense, works like a charm!

For that the config already exists in master... I think there is an Express at TUD in the cupboard in 3100.

@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 21, 2024
@riot-ci
Copy link

riot-ci commented Nov 21, 2024

Murdock results

✔️ PASSED

5dd5400 feather-nrf52840: add config for NeoPixel LED

Success Failures Total Runtime
578 0 578 05m:01s

Artifacts

@maribu maribu added this pull request to the merge queue Nov 21, 2024
Merged via the queue into RIOT-OS:master with commit 88839ae Nov 21, 2024
27 checks passed
@miri64 miri64 deleted the feather-nrf52840/enh/ws281x branch November 22, 2024 09:08
@MrKevinWeiss MrKevinWeiss added this to the Release 2025.01 milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants