Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys/stdio: stdio_available is always false with missing stdin module #21040

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

mguetschow
Copy link
Contributor

Contribution description

If I understand the purpose of the pseudomodule stdin correctly, it should describe the fact that the user wants to read from the stdio. If not selected, stdio_available (which returns the number of bytes available to be read) should thus always return zero.

Testing procedure

Wait for @benpicco's take on this. Check for regressions via CI.

Issues/PRs references

Encountered while working on #21039.

@github-actions github-actions bot added the Area: sys Area: System label Nov 25, 2024
@mguetschow mguetschow requested a review from benpicco November 25, 2024 15:29
@mguetschow mguetschow added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 25, 2024
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is correct!

@riot-ci
Copy link

riot-ci commented Nov 25, 2024

Murdock results

✔️ PASSED

5715828 sys/stdio: stdio_available is always false with missing stdin module

Success Failures Total Runtime
10249 0 10249 16m:13s

Artifacts

@benpicco benpicco added this pull request to the merge queue Nov 26, 2024
Merged via the queue into RIOT-OS:master with commit 5e6e34e Nov 26, 2024
27 checks passed
@mguetschow mguetschow deleted the stdio-available branch November 26, 2024 15:14
@mguetschow
Copy link
Contributor Author

Thank you! 🎉

@MrKevinWeiss MrKevinWeiss added this to the Release 2025.01 milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants