Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_in_readme.sh: tell dev _which_ README.md #21044

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Nov 26, 2024

Contribution description

I was a bit confused that the static tests were asking me to add the example to README.md but not telling me which README.md (so I assumed the one in root..., which did not fix it...). So here is my proposal to fix it.

Testing procedure

@AnnsAnns' approval?

Issues/PRs references

Follow-up on #20957.

@github-actions github-actions bot added the Area: tools Area: Supplementary tools label Nov 26, 2024
Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@AnnsAnns AnnsAnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, I can see how that could be confusing 👍

@mguetschow mguetschow added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 26, 2024
@mguetschow mguetschow enabled auto-merge November 26, 2024 20:37
@riot-ci
Copy link

riot-ci commented Nov 26, 2024

Murdock results

✔️ PASSED

7160166 check_in_readme.sh: tell dev which README.md

Success Failures Total Runtime
1 0 1 01m:23s

Artifacts

@mguetschow mguetschow added this pull request to the merge queue Nov 26, 2024
Merged via the queue into RIOT-OS:master with commit df63e81 Nov 26, 2024
28 checks passed
@miri64 miri64 deleted the tools/enh/examples/README.md branch November 26, 2024 21:17
@MrKevinWeiss MrKevinWeiss added this to the Release 2025.01 milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants