Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/lwip: fix unused parameter error, when DEVELHELP = 0 #21082

Merged
merged 1 commit into from
Dec 13, 2024
Merged

pkg/lwip: fix unused parameter error, when DEVELHELP = 0 #21082

merged 1 commit into from
Dec 13, 2024

Conversation

krzysztof-cabaj
Copy link
Contributor

Contribution description

This PR fixes compilation error for applications which utilize LWIP, when DEVELHELP is set to 0.

Testing procedure

Enable LWIP for IPv4 or IPv6 on examples/gcoap (in Makefile set 1 to LWIP_IPV4 or LWIP_IPV6 lines 17 or 18) and disable DEVELHELP (in Makefile set 0 or comment line 63).

Without this PR compilation ends with error:

"make" -C /data/RIOT/RIOT/pkg/lwip/contrib
/data/RIOT/RIOT/pkg/lwip/contrib/_netif.c: In function 'netif_set_opt':
/data/RIOT/RIOT/pkg/lwip/contrib/_netif.c:87:39: error: unused parameter 'value_len' [-Werror=unused-parameter]
   87 |                   void *value, size_t value_len)
      |                                ~~~~~~~^~~~~~~~~
cc1: all warnings being treated as errors

With this PR everything works fine.

Issues/PRs references

None

@github-actions github-actions bot added Area: network Area: Networking Area: pkg Area: External package ports labels Dec 13, 2024
@benpicco benpicco added Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Dec 13, 2024
@krzysztof-cabaj
Copy link
Contributor Author

Wow. @benpicco Thanks for very, very rapid (🚀) reaction :D

@riot-ci
Copy link

riot-ci commented Dec 13, 2024

Murdock results

✔️ PASSED

72cb835 pkg/lwip: fix unused parameter error - when DEVELHELP = 0

Success Failures Total Runtime
10248 0 10249 17m:26s

Artifacts

@benpicco benpicco added this pull request to the merge queue Dec 13, 2024
Merged via the queue into RIOT-OS:master with commit 775fd55 Dec 13, 2024
28 checks passed
@maribu
Copy link
Member

maribu commented Dec 13, 2024

Wow. @benpicco Thanks for very, very rapid (🚀) reaction :D

Quickdraw

https://github.com/benpicco?achievement=quickdraw&tab=achievements

@MrKevinWeiss MrKevinWeiss added this to the Release 2025.01 milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

Assignees
No one assigned
Labels
Area: network Area: Networking Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer
Projects
None yet
Milestone
Release 2025.01
Development

Successfully merging this pull request may close these issues.
5 participants
@krzysztof-cabaj @riot-ci @maribu @benpicco @MrKevinWeiss