Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tree-wide: use alignas() for alignment #21148

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

tree-wide: use alignas() for alignment #21148

wants to merge 1 commit into from
+75 −50

Conversation

maribu
Copy link
Member

@maribu maribu commented Jan 21, 2025

Contribution description

  • Use of __attribute__((aligned(<NUM>))) is a compiler extension. We can just use alignas(), which is part of the C standard since C11
  • Use of _Alignas() is a keyword since C11 and alignas() the alias provided by <stdalign.h>. But _Alignas() is deprecated since C23. Let's just go for alignas() instead.

Testing procedure

alignas() and __attribute__((aligned())) have the same semantics, but alignas() cannot be placed as freely as the __attribute__((aligned())) variant. But the CI will catch syntax errors.

Issues/PRs references

None

@maribu
tree-wide: use alignas() for alignment
534a2d2 
- Use of `__attribute__((aligned(<NUM>)))` is a compiler extension. We
  can just use `alignas()`, which is part of the C standard since C11
- Use of `_Alignas()` is a keyword since C11 and `alignas()` the alias
  provided by `<stdalign.h>`. But `_Alignas()` is deprecated since C23.
  Let's just go for `alignas()` instead.
@maribu maribu added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 21, 2025
@github-actions github-actions bot added Platform: native Platform: This PR/issue effects the native platform Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: doc Area: Documentation Area: tests Area: tests and testing framework Area: core Area: RIOT kernel. Handle PRs marked with this with care! Area: drivers Area: Device drivers Area: boards Area: Board ports Platform: ESP Platform: This PR/issue effects ESP-based platforms Platform: RISC-V Platform: This PR/issue effects RISC-V-based platforms Area: cpu Area: CPU/MCU ports Area: sys Area: System Area: examples Area: Example Applications labels Jan 21, 2025
@riot-ci
Copy link

riot-ci commented Jan 21, 2025

Murdock results

❌ FAILED

534a2d2 tree-wide: use alignas() for alignment

Success Failures Total Runtime
42 0 9268 01m:31s

Artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri will be requested when the pull request is marked ready for review leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie will be requested when the pull request is marked ready for review aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner will be requested when the pull request is marked ready for review MichelRottleuthner is a code owner

@kaspar030 kaspar030 Awaiting requested review from kaspar030 kaspar030 will be requested when the pull request is marked ready for review kaspar030 is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss will be requested when the pull request is marked ready for review MrKevinWeiss is a code owner

@vincent-d vincent-d Awaiting requested review from vincent-d vincent-d will be requested when the pull request is marked ready for review vincent-d is a code owner

@benpicco benpicco Awaiting requested review from benpicco benpicco will be requested when the pull request is marked ready for review benpicco is a code owner

@dylad dylad Awaiting requested review from dylad dylad will be requested when the pull request is marked ready for review dylad is a code owner

@keestux keestux Awaiting requested review from keestux keestux will be requested when the pull request is marked ready for review keestux is a code owner

@gschorcht gschorcht Awaiting requested review from gschorcht gschorcht will be requested when the pull request is marked ready for review gschorcht is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: core Area: RIOT kernel. Handle PRs marked with this with care! Area: cpu Area: CPU/MCU ports Area: doc Area: Documentation Area: drivers Area: Device drivers Area: examples Area: Example Applications Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Platform: ESP Platform: This PR/issue effects ESP-based platforms Platform: native Platform: This PR/issue effects the native platform Platform: RISC-V Platform: This PR/issue effects RISC-V-based platforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maribu @riot-ci