LOSTANDFOUND.md: add missing URL, fix Markdown typo #21154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
added
CI: ready for build
miri64
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
ACK. Lesson learned: A reviewer should always, always, always check the documentation generated by Murdock (see e.g. #21154 (comment) for this PR) to see if the rendering is right (it does look how @crasbe describes it to be expected. It appears for #18562 this nice Murdock feature was either not in place yet or temporarily deactivated, so @maribu is not to blame here either.
|
Thanks for fixing it! |
|
I suppose I should backport this as well 😬 |
MrKevinWeiss
added
the
Process: needs backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
In Pull Request #18562, the removal of MIPS support was documented and the headline had the right Commit ID, however the URL was not added to the link section below.
In Pull Request #21146, a
:was added after the headline, leading to Doxygen not recognizing the link and therefore not applying it.Unfortunately while this PR was open, I didn't see it in time, so now it has to be fixed afterwards.
I think both PRs are from @MrKevinWeiss, but I don't want to blame him. I fought for hours with the
LOSTANDFOUND.mdto find the bug described in #21106, so I know how easy it is to get Markdown angry :DTesting procedure
The documentation should still build and now show the links (they are still broken because of #21106, BUT there should now be
<a href=...in the headlines.Issues/PRs references
Corrects the regressions introduced in #18562 and #21146.