Include further helper scripts in deb that main ATLAS script sources #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main ATLAS script is sourcing further helper scripts, directly or indirectly, that are currently not included in the deb package built by the make-deb script. Update make-deb to have them included.
|
This is kind of for Debian what #79 is/was for OpenWrt, with a similar solution. |
|
Hi @AtlasMUC As of next release there will be a new build for DEB files available, Debian 11/12 will be supported on x86_64. Please be patient its being worked on, the new version will use dpkg-buildpackage, and not make-deb anymore. Regards, Michel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main
ATLASscript is sourcing further helper scripts, directly or indirectly, that are currently not included in the deb package built by themake-debscript. Updatemake-debto have them included.The issue raised in PR #88 currently hides the fact that those scripts are missing, as the non-supported
sourcecommand triggers an error message by the shell, but theATLASscript itself still continues to work, as well as the core probe functionality, as far as I can see.However, with the (valid) changes proposed in PR #88, the
.trying to source non-existing helper scripts leads to complete abortion of theATLASscript, and thus failure of the probe.