feat: return if no parent for bottm

RIPE-NCC · Jan 14, 2025 · b000aea · b000aea
1 parent 0102f05
commit b000aea
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/whois-api/src/main/java/net/ripe/db/whois/api/rdap/RdapRelationService.java b/whois-api/src/main/java/net/ripe/db/whois/api/rdap/RdapRelationService.java
@@ -94,11 +94,17 @@ private List<IpEntry> searchBottomResources(final IpTree ipTree, final IpInterva
     private void extractBottomMatches(final IpTree ipTree, final IpInterval searchIp,
                                       final IpEntry mostSpecificResource,
                                       final Set<IpEntry> mostSpecificFillingOverlaps) {
+
         mostSpecificFillingOverlaps.add(mostSpecificResource);
 
         final IpInterval mostSpecificInterval = IpInterval.parse(mostSpecificResource.getKey().toString());
         final List<IpEntry> parentList = ipTree.findFirstLessSpecific(mostSpecificInterval);
-        final List<IpEntry> siblingsAndExact = findSiblingsAndExact(ipTree, mostSpecificInterval, parentList);
+
+        if (parentList.isEmpty()){
+            return;
+        }
+
+        final List<IpEntry> siblingsAndExact = findSiblingsAndExact(ipTree, parentList);
 
         final IpInterval firstSibling = (IpInterval)siblingsAndExact.getFirst().getKey();
         final IpInterval lastSibling = (IpInterval)siblingsAndExact.getLast().getKey();
@@ -117,10 +123,7 @@ private static boolean childrenCoverParentRange(final IpInterval firstResource,
                 lastResource.endAsInetAddress().equals(parent.endAsInetAddress());
     }
 
-    private static List<IpEntry> findSiblingsAndExact(final IpTree ipTree, final IpInterval parentResource, final List<IpEntry> parent) {
-        if (parent.isEmpty()){
-            return ipTree.findExact(parentResource);
-        }
+    private static List<IpEntry> findSiblingsAndExact(final IpTree ipTree, final List<IpEntry> parent) {
         return ipTree.findFirstMoreSpecific(IpInterval.parse(parent.getFirst().getKey().toString()));
     }