-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to RDAP RIR-Search (Basic Searches) Feature #1611
base: master
Are you sure you want to change the base?
Conversation
whois-api/src/main/java/net/ripe/db/whois/api/rdap/RdapElasticFullTextSearchService.java
Outdated
Show resolved
Hide resolved
whois-api/src/main/java/net/ripe/db/whois/api/rdap/RdapElasticFullTextSearchService.java
Outdated
Show resolved
Hide resolved
FYI I tested wildcard search with a term that will match a lot of objects (i.e. every inet6num primary key) and the response was returned quickly and limited correctly to 100 results.
|
.type(MultiMatchQueryBuilder.Type.PHRASE_PREFIX) | ||
.operator(Operator.AND); | ||
private QueryBuilder getQueryBuilder(final String[] fields, final String term, final boolean matchExact) { | ||
if (hasWildCard()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MatcExact and hasWildcard seems to be contradictory. if hasWildCard() then createWildCardQuery() else exact match?
This PR contains some fixes for the RDAP RIR-Search (Basic Searches) feature, including:
ips?handle
search input should match against the handle field and not the name field of the object.*
(i.e. match all) to theips?handle
search.*
themselves if they wish.*
(i.e. match all) to theautnums?handle
search.