Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to announcements and talks #43

Open
thenaterhood opened this issue Feb 25, 2016 · 11 comments
Open

Add pagination to announcements and talks #43

thenaterhood opened this issue Feb 25, 2016 · 11 comments
Labels
blocked Progress blocked by another task or issue enhancement

Comments

@thenaterhood
Copy link
Member

Right now, the talks and announcements pages have no pagination and will just continue to get longer. As far as I'm aware, Jekyll doesn't support pagination of multiple things natively so some JavaScript magic or other "creative" method of doing it may need to be implemented. Github pages doesn't allow Jekyll plugins.

@axk4545
Copy link
Member

axk4545 commented Jan 25, 2018

@thenaterhood I think you can use paginate...

@thenaterhood
Copy link
Member Author

In this case maybe not, because paginate assumes you have a single stream of posts. The RITlug site has two streams, one for talks and one for announcements.

@ct-martin
Copy link
Member

I don't have time to look at it for now, but here's the docs page showing that GitHub does support the paginate plugin:

https://help.github.com/articles/configuring-jekyll-plugins/#default-plugins

@ct-martin
Copy link
Member

ct-martin commented Jul 8, 2018

To add some more to this, RITlug's site is organized as a bunch of categories with indexes for each category ("sections" per say). Pageinate (at least the version on GitHub) only pages all categories together, and can't page individual categories. In #151 I'm cheating by limiting to about 2 semesters of posts (and an "archive" page), but this isn't a perfect approach. Unless we want to completely restructure the RITlug site (which I'm not going to do), then this will have to go on the back burner until GitHub decides to change to the new plugin.

For ref:
https://jekyllrb.com/docs/pagination/

@jwflory
Copy link
Member

jwflory commented Jul 10, 2018

I think #151 is probably the best we can do to address this for now. After PR #151 is merged, I suggest we also close this issue as complete / resolved, since there is not a better workaround until GitHub enables support with the pagination plugin. If support is ever added, we can revisit then.

@ct-martin
Copy link
Member

@jwflory how about a "blocked" label? At some point I do want to do it and I might be able to minimally implement some of it in the future

@jwflory
Copy link
Member

jwflory commented Jul 11, 2018

@ct-martin That works – could you elaborate on what exactly is the blocker and what needs to happen to unblock this ticket? This will help if we revisit this six months, a year, or two eboards from now into the future.

@ct-martin
Copy link
Member

@jwflory Sure. The blocker is that there is not an easy way to do this. There are two ways that this will be accomplished:

  1. GitHub updates to the new plugin for pagination
  2. Whoever ends up implementing it fudges the functionality with some Jekyll tricks or pseudo-manually (neither of which are great, but they could be done)

@jwflory jwflory added blocked Progress blocked by another task or issue and removed help wanted labels Jul 11, 2018
@ct-martin
Copy link
Member

Removing announcements from this as the announcements feed is being deprecated. Talks should still be looked at for this.

@Tjzabel
Copy link
Member

Tjzabel commented Oct 25, 2018

@ct-martin is this issue still relevant?

@ct-martin
Copy link
Member

@Tjzabel I'm not sure. It'd be nice if it was, but I may close it soon. Ping me again in a couple weeks to check if there are any GH Pages updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Progress blocked by another task or issue enhancement
Projects
None yet
Development

No branches or pull requests

5 participants