Redesign Summer 2018 #151
Redesign Summer 2018 #151
Conversation
|
@Tjzabel could you block this until we fully discuss in eboard meeting? |
There was a problem hiding this comment.
I left more detailed feedback in-line as a review. Nice work on the redesign, @ct-martin.
Before we merge this, could you also rebase your commits to fewer commits? It is best practice for helping keep the commit history tidy. If you need help doing this, edX has a great tutorial on how to rebase a pull request. I also like this blog post as a way to explain interactive rebasing too.
If you need help with rebasing, I'm happy to help with this too – let me know if you need any. 🙂
| @@ -10,6 +10,7 @@ description: > # this means to ignore newlines until "baseurl:" | |||
| url: 'http://ritlug.com' | |||
| # Build settings | |||
| markdown: kramdown | |||
| permalink: pretty # no .html extension needed/wanted | |||
|
|
||
| - name: CampusGroups | ||
| link: https://campusgroups.rit.edu/student_community?club_id=16071 |
There was a problem hiding this comment.
I think it is best to keep CampusGroups in the footer or clearly linked from the website. Even if we are not actively using it, it is still the platform we use for critical club functions, like elections. It will be helpful to keep this visible and present on our website.
There was a problem hiding this comment.
It's still on both the footer ("RIT Club Page") and on the "get involved" page. I don't want it on the top navbar because it takes up a decent amount of space and we haven't really done much with it. Do you have any suggestions?
There was a problem hiding this comment.
Oh, I missed it in the footer. Instead, could you make the footer and "get involved" page more explicit as "CampusGroups" instead of "RIT Club Page"?
index.html
Outdated
| <h2>Discuss</h2> | ||
| <div class="list-group"> | ||
| <a href="https://rit-lug.slack.com/" class="list-group-item list-group-item-action">Slack (needs <code>@rit.edu</code> email)</a> | ||
| <a href="https://telegram.me/ritlugclub" class="list-group-item list-group-item-action">Telegram</a> |
There was a problem hiding this comment.
When we started the Slack, we made a decision to deprecate the Telegram group and transition away from promoting it in the club. I think it is better to be opinionated on where we point people to join and participate with the club, because:
- Too many options can be too confusing for where to join or participate
- Slack integrates multiple parts of our community and club together in one place (FOSS, projects, announcements channel, etc.).
Since we retired the Telegram group as an unofficial platform, I think we shouldn't mention it on the home page.
There was a problem hiding this comment.
Sure, I can do that. Do you have any suggestions for what I could put there instead so I can keep it visually balanced?
There was a problem hiding this comment.
A link to the Google Group mailing list would be great, I think.
There was a problem hiding this comment.
I'm slightly hesitant to do that due to the number of email-related issues we've had lately. I think this should be an eboard discussion
There was a problem hiding this comment.
(continuing this in main comments thread)
There was a problem hiding this comment.
@ct-martin Email is still a critical part of how we communicate out with the announcements we post to the website. What alternative are you proposing?
There was a problem hiding this comment.
@jwflory We could use CampusGroups or another system like MailChimp or maybe a NameCheap list. If we have something that works reliably I don't mind putting it there, however, we've had half a dozen to a dozen issues with mail this past semester alone that are of a level to concern me. If it's "just a way" of communicating I don't mind it too much, but if we're really promoting it, it should work.
jwflory
dismissed
Tjzabel’s stale review
Dismissing – this was discussed at the last eboard meeting
|
@jwflory random thought: we could solve both of those by putting in CampusGroups but that would also mean we should use it more |
|
@ct-martin I think it's better to establish our identity on the website. We need to use CampusGroups for some RIT functions, but we don't need to base our operations there. |
|
Also, just fixed the footer links to use HTTPS |
|
@jwflory new idea for the columns - move "get involved" to the left one and make an "events" section (ImagineRIT, Maker Faire, etc.) that gets added to the right side. Thoughts? |
|
Just putting my nitpick from the eboard meeting here: the I feel we should consider how programming-centric we would like our site to be, so the club as a whole is more welcoming to non-programming majors and people. Perhaps a more Linux-related blurb would be suitable, or a quote pertaining to the unity open source promotes. |
|
@jibby0 for the record here, we also looked at simpler variations but weren't happy with any of them (we tried: hello, hello RIT, hello world, hello RIT/world) I'm going to add that since it's literally the biggest thing on the page and it's front, center, and top, it should still be some form of greeting. We're trying to drive engagement a lot this semester and I feel that this should try to show a welcoming attitude. I also don't think that's the place for quotes as that would be the opposite of the previous point of welcoming since it indicates that we have (some amount of) a shared ideology, which will likely turn some people away. The exception to that would a "can you do (everything) with Linux"-style thing, but I feel that should go somewhere else. We could try a call-phrase like "hack the planet", which while not everyone would know the reference, still would have some degree of appeal to both newer and older members. The problem again with that though is that less-programming-centric majors might not understand the word "hack" properly. We should also remember that while our primary & target audience is students, we also get parents, administrators, and other people who view our site, and we'll have a particular issue if an administrator takes it badly (remember, we also put this on a screen at events like ImagineRIT and Maker Faire). So while regex might not be understood, they should still get the idea of the greeting, but we also can't make it too, too oriented towards a younger, tech-savvy-ish audience. I do understand that it could end up slightly as gatekeeping if someone thinks they need to understand it to join. My biggest concern is that it's big and it's the first thing that you'll see, so it should be welcoming and inviting. We could just use "RIT Linux Users Group" as something neutral if we decide we don't like the regex, but I also want to know how much we want to block the PR for this. I would be interested in dzho, Schneidy, or SJ's opinion on this, however, to my understanding they are all busy with life or work right now. |
|
@ct-martin I agree, don't block on this. This is more of something to keep in mind as we pursue a more welcoming environment and finish wrapping things up this summer. And I agree, the worst thing to come of reading this is "I don't understand regex,but kinda get what it's saying". There won't be any misconceptions or blatant ideology, which could be more troublesome. |
|
@jibby0 I agree that it'll be understood as a greeting, the other issue was potential gatekeeping. Since I agree that it's likely mundane, I'm going to put forward that we should not block on this now and I'll ping Schneidy end of this week, or next week, since he's busy right now and dzho is overseas. I'm also seeing some other room for minor wording improvements (such as shortening the third line of the orange block), so I think if Flory's issue gets resolved (and no other arise) we should merge this and then open a new issue to discuss potential improvements at a broader scale since we now can change almost anything as I now know what's going on in the site and Bootstrap is a bit more flexible than MDL. Since Flory dislikes issues without a clear deliverable, I think we should set a time limit on it as an initial CFP for the new site as otherwise we'd end up with a lot of issues. |
|
@ct-martin I really like this. The one thing is that I would re-structure the Do category like this:
|
|
Random thought to self: add arrows to the boxes to indicate they can be clicked |
There was a problem hiding this comment.
I enjoy the use of simple regex in the title, I think that it adds flair without being too confusing.
@ct-martin if the boxes have a hover state that indicates that they are click-able then arrows may not be needed.
I agree with @gen1e that the Do category should list Get Involved first.
I don't like how the footer links/site information are laid out, but I think this can be revisited at a later point since the positioning is the same as it currently is on the live site.
Overall a solid improvement!
I would still like to see the mailing list added – in a first pass, I didn't notice it was missing.
When looking closer, I noticed we didn't expand the acronym on the home page. I think it is better to be explicit with RIT Linux Users Group, since RITlug wouldn't be intuitive for a first-time viewer or someone outside of RIT. I think it's important to expand the acronym somewhere on the home page.
+1! |
There was a problem hiding this comment.
I really like the new website design.
The only thing that I would recommend changing is the footer section. I think the entire footer should be a light shade of gray, or, we should have some shadow/line between the footer and the rest of the page. This isn't a blocking issue, just a small design preference.
|
@jrtechs The footer already has a light grey background (in which case maybe a darker one?), and from when I was playing with it I wasn't fond of a horizontal line since there's already a visual border from the bottom of the "latest announcement" (or whatever the page content is). I'm going to put that in he same category as "Hello (RIT|World)" for a new ticket after this gets merged. |
|
@jwflory I noticed that (the acronym) last night but wasn't completely happy with how it looked when it was fully written out; I'll play with it some more in this next round of changes. |
|
Ah, I suppose it's time I also add in my own review. First ImpressionsI like it! The updates you have been doing to the website these past few months have been great! I appreciate you taking the website project upon yourself. I love the color scheme and how the top header is not black any more. Possible ChangesFooterI agree with @jrtechs that the footer could definitely be a darker color, and separate from the main section. I would like to move away from the standard blue links as well, so maybe have a darker grey with white-ish links? Hello RIT|WorldI'm not sure how I feel about this. On one hand, I totally understand having this wording on our page. On the other hand, I don't think it's a great placement or phrasing as the largest text on the screen. I would personally like for the wording to be less programming related, and more of a generic page. Maybe just have "RIT Linux Users Group" as the text? This is a hard one to handle. DoFor the "Do" section, I'm thinking the order should be a little different. My thoughts are: Get Involved, Talks, Projects, GitHub. |
|
@RITlug/eboard-current @gen1e: Made requested changes (& a couple design tweaks). Please let me know what you think and/or if I missed anything. Also, desktop screenshot is properly 1080p this time and sorry the mobile one look really big.
|
|
Also, I shortened the orange block sentences, please let me know what you think of them. |
|
@ct-martin I love the update! I have one last super nit-picky thing in the footer. Under RIT, the Other than that, this looks ready to ship in my eyes. Great work! |
There was a problem hiding this comment.
Changes look good to me. 👍 Since this is a really big PR, I suggest waiting for 2-3 other reviews before merging.
Also, before merging, could you also squash your commits to fewer commits, per git best practices? If you need any help, I recommend either the edX tutorial or this blog post as starting places.
If you need help with this, let me know – I'm happy to help. 🙂
|
@Tjzabel: it does have the |
|
@jwflory will do for both. Was trying to keep different things separate for commits with how much I was changing |
|
@ct-martin Looks good to me |
|
@Tjzabel changed links to "University Website," "GCCIS College of Computing," & "CampusGroups" since the RIT label on all of them was redundant. At some point we should figure out how to put GCCIS there with its proper name while not going across so many lines. |
|
@jwflory I won't reliably have time to rewrite the git history probably until I get back in fall. To not block on me so this can be merged, would you rather I do "Merge & Squash" down to one commit or keep the entire history? |
Pretty links in tabs
Significantly improves organization/readability of folders (for example, was having trouble getting to/from index.html in editor)
A lot of stuff was removed since we didn't actually have it set up right anyway Remove Material Design Lite Delete unused templates
Also, put real content on home page Remove About & CampusGroups from navbar - Takes up valuable space. - About is almost identical to "Get Involved" (which has a more proactive, encouraging tone). - CampusGroups we aren't really using and it's in the footer & Get Involved page
- Dark background - Fixed-width - Improve link names - Update links to HTTPS
ct-martin
force-pushed
the
redesign-fall2018
branch
from
027251f
to
9a0cdf2
Compare
|
Managed to figure out my question. @jwflory if this looks ok to you could you merge? |
|
@ct-martin Excellent, this is perfect. Thanks for rebasing. Merging it in now! 🎬 |
(Fall 2018 prep)
.htmlat the end of links ("pretty links") :)