Faculty advisor: Follow style guide, reorganize / restructure content #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwflory
added
enhancement
Tjzabel
previously requested changes
Mar 24, 2018
| Periodically, the adviser may be needed to resolve issues with the clubs office or with renewing club resources. | ||
| Faculty advisors can take a hands-on or hands-off role. | ||
| Historically, RITlug's advisor is hands-off. | ||
| This assumes the club is in good standing is regular communication with the advisor. |
There was a problem hiding this comment.
Wording is odd with this sentence.
There was a problem hiding this comment.
@Tjzabel Oops, nice catch. I just pushed a new commit to clean this up.
jwflory
dismissed
Tjzabel’s stale review
New commit addresses concern in review; please re-review
Tjzabel
approved these changes
Mar 24, 2018
axk4545
approved these changes
Mar 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the faculty advisor page. There weren't many content changes in this one. Specifically, this PR changes the following:
Tagging RITlug/tasks#8 for tracking purposes.