Move rewrite_low_precision after rewrite_reduce

ROCm · Mar 4, 2024 · 2e0a5c3 · 2e0a5c3
1 parent 1455b0b
commit 2e0a5c3
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/src/include/migraphx/matcher.hpp b/src/include/migraphx/matcher.hpp
@@ -598,8 +598,9 @@ MIGRAPHX_PRED_MATCHER(same_inputs, instruction_ref ins)
 {
     if(ins->inputs().empty())
         return false;
-    auto s = ins->inputs().front();
-    return std::all_of(ins->inputs().begin(), ins->inputs().end(), [&](auto x) { return x == s; });
+    auto input = ins->inputs().front();
+    return std::all_of(
+        ins->inputs().begin(), ins->inputs().end(), [&](auto x) { return x == input; });
 }
 
 MIGRAPHX_PRED_MATCHER(has_same_value, instruction_ref ins)

diff --git a/src/quantization.cpp b/src/quantization.cpp
@@ -41,7 +41,6 @@
 #include <migraphx/make_op.hpp>
 #include <migraphx/pass_manager.hpp>
 #include <migraphx/normalize_ops.hpp>
-#include <migraphx/rewrite_low_precision.hpp>
 #include <set>
 
 namespace migraphx {
@@ -58,7 +57,6 @@ void quantize_fp16(program& prog, const std::vector<std::string>& ins_names)
 {
     run_passes(prog,
                {normalize_ops{},
-                rewrite_low_precision{},
                 optimize_module{{"quantizelinear", "dequantizelinear"}},
                 quantize_fp16_pass{ins_names},
                 optimize_module{{"quantizelinear", "dequantizelinear"}}});

diff --git a/src/targets/gpu/target.cpp b/src/targets/gpu/target.cpp
@@ -45,6 +45,7 @@
 #include <migraphx/register_target.hpp>
 #include <migraphx/replace_allocate.hpp>
 #include <migraphx/rewrite_gelu.hpp>
+#include <migraphx/rewrite_low_precision.hpp>
 #include <migraphx/rewrite_pooling.hpp>
 #include <migraphx/rewrite_reduce.hpp>
 #include <migraphx/rewrite_quantization.hpp>
@@ -154,6 +155,7 @@ std::vector<pass> target::get_passes(migraphx::context& gctx, const compile_opti
         eliminate_data_type{{migraphx::shape::fp8e4m3fnuz_type}, shape::float_type, unsupported_fp8_ops},
         dead_code_elimination{},
         rewrite_reduce{},
+        rewrite_low_precision{},
         dead_code_elimination{},
         optimize_module{},
         fuse_pointwise{},