Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eliminate_nested_converts pass and add unit-tests #2520

Closed
umangyadav opened this issue Dec 6, 2023 · 3 comments
Closed

Add eliminate_nested_converts pass and add unit-tests #2520

umangyadav opened this issue Dec 6, 2023 · 3 comments
Assignees
@umangyadav

Comments

@umangyadav
Copy link
Member

umangyadav commented Dec 6, 2023 •
edited
Loading

#2506 (comment)

eliminate_data_type pass requires removal of nested converts and
there is already a matcher inside simplify_reshapes that does exactly that. need to move this matcher into a separate pass and use that instead.

Add unit-tests . Unit-tests should cover cases like those described in #2517

Some initial work is already here : https://github.com/ROCmSoftwarePlatform/AMDMIGraphX/compare/quant_gemm_fp8...eliminate_nested_converts?expand=1
@umangyadav umangyadav self-assigned this Dec 6, 2023
This was referenced Dec 6, 2023
Merged
Open
Merged
@CharlieL7
Copy link
Collaborator

Working on this, fixing bug

@umangyadav
Copy link
Member Author

@CharlieL7 is this fixed ?

@umangyadav
Copy link
Member Author

umangyadav commented Jul 26, 2024 •
edited
Loading

Fixed with #2525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@umangyadav umangyadav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CharlieL7 @umangyadav