-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print Ref compiled program in verify tests #2530
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, doesn't solve the issue from #2525 however because the problem is that when ref
runs with fp16 the accuracy is inherently lower than when running with higher floating point precision. Comparing other targets to ref in the verify
tests then becomes as wild goose chase to figure out where the error is coming from.
Yes this doesn't solve anything. This is just useful for debugging purposes. |
This build is OK for merge ✅ |
🔴bert_base_cased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output🔴distilgpt2_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
Solution to #2525 and #2520 would mean changing compilation pipeline for ref program.
It is easier for debug purpose to print compiled ref program for comparison.
This PR allows to print it. Previously verify test printed uncompiled program for "ref".