-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic ConstantOfShape #2111
Dynamic ConstantOfShape #2111
Conversation
… into dyn_allocate
…raphX into dyn_parse_constant_of_shape
… into dyn_parse_constant_of_shape
Codecov Report
@@ Coverage Diff @@
## develop #2111 +/- ##
===========================================
- Coverage 91.49% 91.48% -0.02%
===========================================
Files 430 427 -3
Lines 16129 15942 -187
===========================================
- Hits 14758 14585 -173
+ Misses 1371 1357 -14
|
This build is OK for merge ✅ |
🔴torchvision-inceptionv3_1: FAILED: MIGraphX is not within tolerance - check verbose output🔴cadene-dpn92_1: FAILED: MIGraphX is not within tolerance - check verbose output🔴slim-inceptionv4_1: FAILED: MIGraphX is not within tolerance - check verbose output |
… into dyn_parse_constant_of_shape
use int64 for output_dims (ONNX spec) default test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix CI but LGTM here. @pfultz2 / @umangyadav ?
EXPECT(p == prog); | ||
} | ||
|
||
TEST_CASE(const_of_shape_dyn_int64_test) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add tests inside verify_onnx.cpp as well ?
marked as high priority as depending PRs merged in already |
fill
ref operator #2087ConstantOfShape
work with a variable dimensions input