Dont insert reshapes when converting pooling to reduce #2149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2149 +/- ##
========================================
Coverage 91.53% 91.53%
========================================
Files 429 429
Lines 16011 16009 -2
========================================
- Hits 14655 14654 -1
+ Misses 1356 1355 -1
|
|
Performance tests have compilation errors, can you look into it ? |
This build is not recommended to merge 🔴 |
🔴torchvision-inceptionv3_1: FAILED: MIGraphX is not within tolerance - check verbose output🔴cadene-dpn92_1: FAILED: MIGraphX is not within tolerance - check verbose output🔴slim-inceptionv4_1: FAILED: MIGraphX is not within tolerance - check verbose output |
|
@pfultz2 accuracy tests are still failing during compile. Can you check ? |
@umangyadav I pushed a fix. |
umangyadav
reviewed
Sep 20, 2023
| instruction_ref pooling{}; | ||
|
|
||
| std::vector<std::int64_t> axes(lens.size() - 2); | ||
| std::iota(axes.begin(), axes.end(), 2); |
There was a problem hiding this comment.
Should this be doing any checks for the Layout ?
There was a problem hiding this comment.
@pfultz2 sorry i missed this comment before approving. Would this require check on the layout ?
umangyadav
reviewed
Sep 20, 2023
| @@ -122,6 +122,11 @@ struct find_nop_reshapes | |||
| reshapes.insert("pad"); | |||
| reshapes.insert("slice"); | |||
| reshapes.insert("transpose"); | |||
| reshapes.insert("reduce_mean"); | |||
There was a problem hiding this comment.
Would be better to assert that axes are either empty resulting in no-op or
axes lengths are 1.
is it improving reduce fusion ? Which of the matcher is helping doing that ? |
umangyadav
approved these changes
Sep 20, 2023
causten
requested review from
TedThemistokleous
and removed request for
kahmed10
TedThemistokleous
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve fusions.