Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move stash for onnxrt build to use All targets vs Hip Clang #2236

Closed
wants to merge 3 commits into from
Closed

Move stash for onnxrt build to use All targets vs Hip Clang #2236

wants to merge 3 commits into from

Conversation

TedThemistokleous
Copy link
Collaborator

Trying this in hopes of fixing odd ORT build issues we're seeing.

@TedThemistokleous
Move stash for onnxrt build to use All targets vs Hip Clang
ef6eab0 
Trying this in hopes of fixing odd ORT build issues we're seeing.
@TedThemistokleous TedThemistokleous added onnxruntime PR changes interaction between MIGraphX and Onnxruntime bugfix Fixes a bug found in the code. Continous Integration Pull request updates parts of continous integration pipeline labels Sep 22, 2023
@TedThemistokleous TedThemistokleous self-assigned this Sep 22, 2023
@TedThemistokleous TedThemistokleous linked an issue Sep 22, 2023 that may be closed by this pull request
Figure out why AttentionBatch1_Float16 fails ORT CI #2228
Closed
@TedThemistokleous TedThemistokleous added the skip bot checks Skips the Performance and Accuracy CI tests label Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023 •
edited
Loading

Codecov Report

Merging #2236 (3a697b6) into develop (434a06c) will not change coverage.
The diff coverage is n/a.

❗ Current head 3a697b6 differs from pull request most recent head 7fafbb6. Consider uploading reports for the commit 7fafbb6 to get more accurate results

@@           Coverage Diff            @@
##           develop    #2236   +/-   ##
========================================
  Coverage    91.53%   91.53%           
========================================
  Files          429      429           
  Lines        16011    16011           
========================================
  Hits         14655    14655           
  Misses        1356     1356

@causten
Copy link
Collaborator

causten commented Sep 22, 2023

Add an env print to the ONNX Runtime job, that will help identify the specific server just in case the full Jenkins log gets the print order messed up

@pfultz2
Copy link
Collaborator

pfultz2 commented Sep 22, 2023

Why do you think this would make a difference? Its the same gpu build.

@umangyadav
Copy link
Member

Why do you think this would make a difference? Its the same gpu build.

yeah i don't think it will be helpful.

@TedThemistokleous
Copy link
Collaborator Author

Closing this out as I believe the issue doesn't seem to be related to build used / we're seeing it again.

@causten causten deleted the jenkins_stash_migx_all_targets branch January 5, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umangyadav umangyadav umangyadav approved these changes

@causten causten causten approved these changes

Assignees

@TedThemistokleous TedThemistokleous

Labels
bugfix Fixes a bug found in the code. Continous Integration Pull request updates parts of continous integration pipeline onnxruntime PR changes interaction between MIGraphX and Onnxruntime skip bot checks Skips the Performance and Accuracy CI tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Figure out why AttentionBatch1_Float16 fails ORT CI
4 participants
@TedThemistokleous @causten @pfultz2 @umangyadav