[mlir] Apply is_mlir_conv predicate in standalone MLIr offloading #2249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the is_mlir_conv predicate wasn't being used when offloading standalone convolutions to MLIR on Navi3x, which caused failures relating to being unable to construct the MLIR program when a 3D convlolution was passed in. Fixes ROCm/rocMLIR-internal#1153 This commit amends the standalone lowering to use said predicate, as well as to include quant_convolution and quant_dot into the set of operations that get a standalone lowering.
jerryyin
approved these changes
Sep 26, 2023
pfultz2
approved these changes
Sep 26, 2023
Codecov Report
@@ Coverage Diff @@
## develop #2249 +/- ##
========================================
Coverage 91.53% 91.53%
========================================
Files 429 429
Lines 16011 16009 -2
========================================
- Hits 14655 14654 -1
+ Misses 1356 1355 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the is_mlir_conv predicate wasn't being used when offloading standalone convolutions to MLIR on Navi3x, which caused failures relating to being unable to construct the MLIR program when a 3D convlolution was passed in.
Fixes
https://github.com/ROCmSoftwarePlatform/rocMLIR-internal/issues/1153
This commit amends the standalone lowering to use said predicate, as well as to include quant_convolution and quant_dot into the set of operations that get a standalone lowering.