Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify full path for libamdhip64.so #2264

Merged
merged 5 commits into from
Oct 5, 2023
Merged

Specify full path for libamdhip64.so #2264

merged 5 commits into from
Oct 5, 2023

Conversation

ahsan-ca
Copy link
Contributor

test_py_3.6_gpu_async complains about a missing shared library libamdhip64.so
on sles, specifying the full path seems to fix the issue.
This PR makes the change to add the full path to the shared library provided
the shared library exists at that path.

@ahsan-ca ahsan-ca added bug Something isn't working SLES Changes for SLES Environments labels Sep 28, 2023
@ahsan-ca ahsan-ca self-assigned this Sep 28, 2023
@ahsan-ca ahsan-ca linked an issue Sep 28, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #2264 (6b1745f) into develop (f5411e0) will not change coverage.
The diff coverage is n/a.

❗ Current head 6b1745f differs from pull request most recent head faec5b3. Consider uploading reports for the commit faec5b3 to get more accurate results

@@           Coverage Diff            @@
##           develop    #2264   +/-   ##
========================================
  Coverage    91.50%   91.50%           
========================================
  Files          431      431           
  Lines        16140    16140           
========================================
  Hits         14769    14769           
  Misses        1371     1371           

@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
e09dc3
Rate old
63e354
Diff Compare
torchvision-resnet50 64 2,326.09 2,325.94 0.01%
torchvision-resnet50_fp16 64 5,345.05 5,333.29 0.22%
torchvision-densenet121 32 1,841.42 1,848.06 -0.36%
torchvision-densenet121_fp16 32 3,421.34 3,418.10 0.09%
torchvision-inceptionv3 32 1,299.10 1,294.23 0.38%
torchvision-inceptionv3_fp16 32 2,540.73 2,541.36 -0.02%
cadene-inceptionv4 16 620.92 620.75 0.03%
cadene-resnext64x4 16 589.13 588.76 0.06%
slim-mobilenet 64 7,212.74 7,218.21 -0.08%
slim-nasnetalarge 64 236.65 236.55 0.04%
slim-resnet50v2 64 2,559.38 2,558.14 0.05%
bert-mrpc-onnx 8 825.08 824.41 0.08%
bert-mrpc-tf 1 388.43 389.07 -0.17%
pytorch-examples-wlang-gru 1 296.40 295.79 0.21%
pytorch-examples-wlang-lstm 1 312.04 315.61 -1.13%
torchvision-resnet50_1 1 553.27 548.70 0.83%
torchvision-inceptionv3_1 1 304.33 298.63 1.91%
cadene-dpn92_1 1 350.49 352.88 -0.68%
cadene-resnext101_1 1 220.23 219.79 0.20%
slim-vgg16_1 1 224.27 224.21 0.03%
slim-mobilenet_1 1 1,478.97 1,503.49 -1.63%
slim-inceptionv4_1 1 217.46 214.27 1.49%
onnx-taau-downsample 1 307.04 305.49 0.51%
dlrm-criteoterabyte 1 21.71 21.70 0.04%
dlrm-criteoterabyte_fp16 1 40.64 40.70 -0.14%
agentmodel 1 5,859.12 5,862.39 -0.06%
unet_fp16 2 55.25 55.20 0.08%
resnet50v1_fp16 1 760.15 760.34 -0.03%
bert_base_cased_fp16 64 971.85 971.29 0.06%
bert_large_uncased_fp16 32 305.42 305.32 0.03%
bert_large_fp16 1 166.65 167.13 -0.29%
distilgpt2_fp16 16 1,352.40 1,352.49 -0.01%

This build is OK for merge ✅

@migraphx-bot
Copy link
Collaborator


    :white_check_mark:bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

    :white_check_mark:bert-mrpc-tf: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

    :white_check_mark:torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:torchvision-inceptionv3_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:cadene-dpn92_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:cadene-resnext101_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-vgg16_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-mobilenet_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-inceptionv4_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

    :white_check_mark:agentmodel: PASSED: MIGraphX meets tolerance

    :white_check_mark:unet: PASSED: MIGraphX meets tolerance

    :white_check_mark:resnet50v1: PASSED: MIGraphX meets tolerance

🔴bert_base_cased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


    :white_check_mark:bert_large: PASSED: MIGraphX meets tolerance

🔴distilgpt2_fp16: FAILED: MIGraphX is not within tolerance - check verbose output

@ahsan-ca ahsan-ca requested review from umangyadav and causten October 4, 2023 19:11
@ahsan-ca ahsan-ca force-pushed the lib-path-issue-sles branch from 19f8e51 to 53314de Compare October 4, 2023 19:18
@ahsan-ca
Copy link
Contributor Author

ahsan-ca commented Oct 4, 2023

Modified the PR to check for paths in the order below:

  1. rocm_path env variable.
  2. /opt/rocm.
  3. /opt/rocm-*

@ahsan-ca ahsan-ca force-pushed the lib-path-issue-sles branch from 53314de to d481675 Compare October 4, 2023 19:43
@causten causten merged commit 65c37c3 into develop Oct 5, 2023
14 of 15 checks passed
@causten causten deleted the lib-path-issue-sles branch October 5, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working SLES Changes for SLES Environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing libamdhip64.so for test_py_3.6_gpu_async on sles
5 participants