-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify full path for libamdhip64.so #2264
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umangyadav
reviewed
Sep 28, 2023
Codecov Report
@@ Coverage Diff @@
## develop #2264 +/- ##
========================================
Coverage 91.50% 91.50%
========================================
Files 431 431
Lines 16140 16140
========================================
Hits 14769 14769
Misses 1371 1371 |
pfultz2
approved these changes
Oct 2, 2023
This build is OK for merge ✅ |
🔴bert_base_cased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output🔴distilgpt2_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
ahsan-ca
force-pushed
the
lib-path-issue-sles
branch
from
October 4, 2023 19:18
19f8e51
to
53314de
Compare
Modified the PR to check for paths in the order below:
|
ahsan-ca
force-pushed
the
lib-path-issue-sles
branch
from
October 4, 2023 19:43
53314de
to
d481675
Compare
umangyadav
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_py_3.6_gpu_async complains about a missing shared library libamdhip64.so
on sles, specifying the full path seems to fix the issue.
This PR makes the change to add the full path to the shared library provided
the shared library exists at that path.