Reset HIP status using hipGetLastError()
#2272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfultz2
reviewed
Oct 2, 2023
pfultz2
reviewed
Oct 2, 2023
pfultz2
reviewed
Oct 2, 2023
pfultz2
reviewed
Oct 2, 2023
pfultz2
reviewed
Oct 2, 2023
Codecov Report
@@ Coverage Diff @@
## develop #2272 +/- ##
========================================
Coverage 91.49% 91.49%
========================================
Files 430 430
Lines 16129 16129
========================================
Hits 14758 14758
Misses 1371 1371 |
pfultz2
approved these changes
Oct 2, 2023
TedThemistokleous
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime is making change such that
hipGetLastError()would return error of the first failed HIP call not the last.This PR makes changes inside MIGraphX to comply with that.