Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update version after branch #2273

Merged
merged 2 commits into from
Oct 3, 2023
Merged

update version after branch #2273

merged 2 commits into from
Oct 3, 2023

Conversation

causten
Copy link
Collaborator

@causten causten commented Oct 2, 2023

This should have been done a couple of months ago but changing version of migraphx since we branched rocm5.7 (months ago). Currently migraphx version lists 2.7 for both the 5.7 and Develop branch. I'm moving our version to 2.8 instead of 3.0.

@causten causten requested review from pfultz2 and umangyadav October 2, 2023 21:11
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #2273 (f3455ed) into develop (60b8b09) will not change coverage.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

❗ Current head f3455ed differs from pull request most recent head f0ebd94. Consider uploading reports for the commit f0ebd94 to get more accurate results

@@           Coverage Diff            @@
##           develop    #2273   +/-   ##
========================================
  Coverage    91.50%   91.50%           
========================================
  Files          430      430           
  Lines        16133    16133           
========================================
  Hits         14762    14762           
  Misses        1371     1371           

@umangyadav umangyadav added the skip bot checks Skips the Performance and Accuracy CI tests label Oct 2, 2023
@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
726a31
Rate old
f3939b
Diff Compare
torchvision-resnet50 64 2,323.45 2,326.02 -0.11%
torchvision-resnet50_fp16 64 5,355.83 5,358.11 -0.04%
torchvision-densenet121 32 1,847.37 1,848.23 -0.05%
torchvision-densenet121_fp16 32 3,411.56 3,420.57 -0.26%
torchvision-inceptionv3 32 1,295.70 1,295.65 0.00%
torchvision-inceptionv3_fp16 32 2,534.63 2,538.01 -0.13%
cadene-inceptionv4 16 618.96 620.06 -0.18%
cadene-resnext64x4 16 588.40 589.68 -0.22%
slim-mobilenet 64 7,196.05 7,220.02 -0.33%
slim-nasnetalarge 64 236.24 236.64 -0.17%
slim-resnet50v2 64 2,556.84 2,556.96 -0.00%
bert-mrpc-onnx 8 824.70 824.91 -0.03%
bert-mrpc-tf 1 387.19 389.45 -0.58%
pytorch-examples-wlang-gru 1 301.85 294.32 2.56%
pytorch-examples-wlang-lstm 1 316.63 314.41 0.71%
torchvision-resnet50_1 1 548.75 549.59 -0.15%
torchvision-inceptionv3_1 1 306.94 303.23 1.22%
cadene-dpn92_1 1 355.08 356.62 -0.43%
cadene-resnext101_1 1 219.39 220.18 -0.36%
slim-vgg16_1 1 223.99 224.38 -0.17%
slim-mobilenet_1 1 1,510.25 1,514.28 -0.27%
slim-inceptionv4_1 1 220.79 219.17 0.74%
onnx-taau-downsample 1 307.33 306.29 0.34%
dlrm-criteoterabyte 1 21.69 21.70 -0.05%
dlrm-criteoterabyte_fp16 1 40.75 40.75 -0.00%
agentmodel 1 5,763.99 5,861.32 -1.66%
unet_fp16 2 55.16 55.21 -0.08%
resnet50v1_fp16 1 765.60 768.13 -0.33%
bert_base_cased_fp16 64 970.65 971.58 -0.10%
bert_large_uncased_fp16 32 305.11 305.22 -0.04%
bert_large_fp16 1 167.60 166.81 0.47%
distilgpt2_fp16 16 1,351.75 1,353.09 -0.10%

This build is OK for merge ✅

@migraphx-bot
Copy link
Collaborator


    :white_check_mark:bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

    :white_check_mark:bert-mrpc-tf: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

    :white_check_mark:torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:torchvision-inceptionv3_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:cadene-dpn92_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:cadene-resnext101_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-vgg16_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-mobilenet_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-inceptionv4_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

    :white_check_mark:agentmodel: PASSED: MIGraphX meets tolerance

    :white_check_mark:unet: PASSED: MIGraphX meets tolerance

    :white_check_mark:resnet50v1: PASSED: MIGraphX meets tolerance

🔴bert_base_cased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


    :white_check_mark:bert_large: PASSED: MIGraphX meets tolerance

🔴distilgpt2_fp16: FAILED: MIGraphX is not within tolerance - check verbose output

@causten causten merged commit b72cae6 into develop Oct 3, 2023
15 checks passed
@causten causten deleted the version_rocm60 branch October 3, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip bot checks Skips the Performance and Accuracy CI tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants