-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QlinearGlobalAveragePool operator #2297
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2297 +/- ##
===========================================
- Coverage 91.33% 91.31% -0.03%
===========================================
Files 434 435 +1
Lines 16262 16290 +28
===========================================
+ Hits 14853 14875 +22
- Misses 1409 1415 +6
|
This build is OK for merge ✅ |
🔴bert_base_cased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output🔴distilgpt2_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
|
||
*/ | ||
|
||
struct parse_qlinearglobalaveragepool : op_parser<parse_qlinearglobalaveragepool> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should just name this parser as parse_qlinearpool
so it can be used in the future for other types of pooling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Paul, (agreed for the future steps..) but, for expediency, I suggest we do it for the next quantized pooling operator. Else, it would mean adding code for operators() etc., I believe, and I will have to verify the code again.. with no additional value add for now. Thanks.
https://github.com/microsoft/onnxruntime/blob/main/docs/ContribOperators.md#com.microsoft.QLinearGlobalAveragePool