Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set compile options from accuracy checker #2298

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

CharlieL7
Copy link
Collaborator

Importantly allows you to set disable_fast_math from the accuracy checker.

@TedThemistokleous TedThemistokleous added the enhancement New feature or request label Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #2298 (b0eab3e) into develop (65c37c3) will not change coverage.
The diff coverage is n/a.

❗ Current head b0eab3e differs from pull request most recent head 11a66fd. Consider uploading reports for the commit 11a66fd to get more accurate results

@@           Coverage Diff            @@
##           develop    #2298   +/-   ##
========================================
  Coverage    91.50%   91.50%           
========================================
  Files          431      431           
  Lines        16140    16140           
========================================
  Hits         14769    14769           
  Misses        1371     1371           

@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
11a66f
Rate old
65c37c
Diff Compare
torchvision-resnet50 64 2,323.04 2,324.63 -0.07%
torchvision-resnet50_fp16 64 5,359.73 5,357.98 0.03%
torchvision-densenet121 32 1,846.26 1,847.88 -0.09%
torchvision-densenet121_fp16 32 3,414.03 3,409.96 0.12%
torchvision-inceptionv3 32 1,294.17 1,296.14 -0.15%
torchvision-inceptionv3_fp16 32 2,536.50 2,534.23 0.09%
cadene-inceptionv4 16 619.96 620.23 -0.04%
cadene-resnext64x4 16 588.93 588.45 0.08%
slim-mobilenet 64 7,208.76 7,215.95 -0.10%
slim-nasnetalarge 64 236.22 236.51 -0.12%
slim-resnet50v2 64 2,555.08 2,555.59 -0.02%
bert-mrpc-onnx 8 824.89 825.02 -0.02%
bert-mrpc-tf 1 389.35 389.38 -0.01%
pytorch-examples-wlang-gru 1 297.50 294.47 1.03%
pytorch-examples-wlang-lstm 1 306.59 307.96 -0.45%
torchvision-resnet50_1 1 546.49 544.78 0.31%
torchvision-inceptionv3_1 1 304.55 305.19 -0.21%
cadene-dpn92_1 1 356.74 352.21 1.28%
cadene-resnext101_1 1 219.53 220.12 -0.26%
slim-vgg16_1 1 223.93 224.29 -0.16%
slim-mobilenet_1 1 1,510.76 1,497.40 0.89%
slim-inceptionv4_1 1 216.82 214.96 0.86%
onnx-taau-downsample 1 307.11 306.79 0.10%
dlrm-criteoterabyte 1 21.69 21.67 0.09%
dlrm-criteoterabyte_fp16 1 40.73 40.71 0.05%
agentmodel 1 5,828.08 5,776.01 0.90%
unet_fp16 2 55.15 55.16 -0.01%
resnet50v1_fp16 1 755.93 766.51 -1.38%
bert_base_cased_fp16 64 970.24 971.03 -0.08%
bert_large_uncased_fp16 32 304.94 305.05 -0.03%
bert_large_fp16 1 166.83 166.83 0.00%
distilgpt2_fp16 16 1,350.95 1,350.80 0.01%

This build is OK for merge ✅

@migraphx-bot
Copy link
Collaborator


    :white_check_mark:bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

    :white_check_mark:bert-mrpc-tf: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

    :white_check_mark:torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:torchvision-inceptionv3_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:cadene-dpn92_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:cadene-resnext101_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-vgg16_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-mobilenet_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-inceptionv4_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

    :white_check_mark:agentmodel: PASSED: MIGraphX meets tolerance

    :white_check_mark:unet: PASSED: MIGraphX meets tolerance

    :white_check_mark:resnet50v1: PASSED: MIGraphX meets tolerance

🔴bert_base_cased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


    :white_check_mark:bert_large: PASSED: MIGraphX meets tolerance

🔴distilgpt2_fp16: FAILED: MIGraphX is not within tolerance - check verbose output

@causten causten merged commit c7f0fbc into develop Oct 6, 2023
16 checks passed
@causten causten deleted the accuracy_checker_compile_options branch October 6, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request simple small or simple changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants