Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

edit in tools check_stamped #2305

Merged
merged 8 commits into from
Oct 11, 2023
Merged

edit in tools check_stamped #2305

merged 8 commits into from
Oct 11, 2023

Conversation

NBolade-224
Copy link
Contributor

.

@NBolade-224 NBolade-224 changed the title removed for loop removed for loop in tools check_stamped Oct 8, 2023
@NBolade-224 NBolade-224 changed the title removed for loop in tools check_stamped edit in tools check_stamped Oct 8, 2023
@NBolade-224 NBolade-224 requested a review from umangyadav October 8, 2023 21:10
@TedThemistokleous TedThemistokleous added the Cleanup Cleans up code from stale bits/warnings/previous changes for a previous feature PR label Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023 •
edited
Loading

Codecov Report

Merging #2305 (e22a7c0) into develop (136df3d) will increase coverage by 0.00%.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

❗ Current head e22a7c0 differs from pull request most recent head ae9f3d1. Consider uploading reports for the commit ae9f3d1 to get more accurate results

@@           Coverage Diff            @@
##           develop    #2305   +/-   ##
========================================
  Coverage    91.45%   91.45%           
========================================
  Files          433      433           
  Lines        16175    16177    +2     
========================================
+ Hits         14793    14795    +2     
  Misses        1382     1382

see 8 files with indirect coverage changes

causten
causten approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@causten causten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@causten causten merged commit c58e7d8 into ROCm:develop Oct 11, 2023
11 of 12 checks passed
@NBolade-224 NBolade-224 deleted the dev-tools branch November 19, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TedThemistokleous TedThemistokleous TedThemistokleous approved these changes

@causten causten causten approved these changes

@umangyadav umangyadav Awaiting requested review from umangyadav

Assignees
No one assigned
Labels
Cleanup Cleans up code from stale bits/warnings/previous changes for a previous feature PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NBolade-224 @causten @umangyadav @TedThemistokleous