Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scatter operator for nonstandard shapes #2314

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

TedThemistokleous
Copy link
Collaborator

remove standard() shape check for scatter inputs. Fixes error seen for non standard inputs

remove standard() shape check for scatter inputs.
@TedThemistokleous TedThemistokleous added the bugfix Fixes a bug found in the code. label Oct 11, 2023
@TedThemistokleous TedThemistokleous self-assigned this Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #2314 (2ff238d) into develop (c58e7d8) will decrease coverage by 0.01%.
Report is 3 commits behind head on develop.
The diff coverage is 100.00%.

❗ Current head 2ff238d differs from pull request most recent head fb6b07a. Consider uploading reports for the commit fb6b07a to get more accurate results

@@             Coverage Diff             @@
##           develop    #2314      +/-   ##
===========================================
- Coverage    91.45%   91.45%   -0.01%     
===========================================
  Files          433      433              
  Lines        16175    16174       -1     
===========================================
- Hits         14793    14792       -1     
  Misses        1382     1382              
Files Coverage Δ
src/api/api.cpp 72.36% <ø> (ø)
src/api/include/migraphx/migraphx.hpp 98.63% <ø> (ø)
src/include/migraphx/auto_register.hpp 100.00% <ø> (ø)
src/include/migraphx/float_equal.hpp 100.00% <ø> (ø)
src/include/migraphx/generate.hpp 76.92% <ø> (ø)
src/include/migraphx/instruction_ref.hpp 100.00% <ø> (ø)
src/include/migraphx/matcher.hpp 97.13% <ø> (-0.02%) ⬇️
src/include/migraphx/op/nonmaxsuppression.hpp 98.47% <ø> (ø)
src/include/migraphx/op/roialign.hpp 99.16% <ø> (ø)
src/include/migraphx/op/scatter.hpp 100.00% <100.00%> (ø)
... and 4 more

Copy link
Member

@umangyadav umangyadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add tests

@TedThemistokleous
Copy link
Collaborator Author

add tests

Added

@causten causten merged commit bc7db10 into develop Oct 11, 2023
14 of 15 checks passed
@causten causten deleted the fix_scatter_nonstandard_shapes branch October 11, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a bug found in the code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants