clang-format needed for build

[causten]

PR 2288 requires clang-format, this adds it to the Dockerfiles needed in CI to use the make generate script work.

[pfultz2]

Also, why was #2288 merged when it wasn't passing CI?

[codecov]

Codecov Report

Merging #2320 (6104501) into develop (34b68ee) will not change coverage.
The diff coverage is n/a.

❗ Current head 6104501 differs from pull request most recent head c564b00. Consider uploading reports for the commit c564b00 to get more accurate results

@@           Coverage Diff            @@
##           develop    #2320   +/-   ##
========================================
  Coverage    91.45%   91.45%           
========================================
  Files          433      433           
  Lines        16174    16174           
========================================
  Hits         14792    14792           
  Misses        1382     1382           

[TedThemistokleous]

Also, why was #2288 merged when it wasn't passing CI?

Looks like it did pass once develop was merged.

[apwojcik]

Also, why was #2288 merged when it wasn't passing CI?

I explained in the PR the cause of the CI failure of cppcheck - the failure was unrelated to this PR.

[apwojcik]

Here is how #2288 is searching for clang-format.

find_program(CLANG_FORMAT clang-format PATHS /opt/rocm/llvm $ENV{HIP_PATH})

It is supposed to search in /opt/rocm/llvm. The $ENV{HIP_PATH} is for Windows - that is how HIP SDK reveals its installation location.