Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing exports on Windows #2327

Merged
merged 3 commits into from
Oct 14, 2023
Merged

fix missing exports on Windows #2327

merged 3 commits into from
Oct 14, 2023

Conversation

apwojcik
Copy link
Collaborator

A few missing EXPORTS were revealed after rebasing to the top of the develop branch.

@apwojcik apwojcik added skip bot checks Skips the Performance and Accuracy CI tests Windows Related changes for Windows Environments labels Oct 13, 2023
@apwojcik apwojcik requested a review from pfultz2 October 13, 2023 13:30
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #2327 (a4cea55) into develop (05e3659) will decrease coverage by 0.13%.
Report is 2 commits behind head on develop.
The diff coverage is 59.72%.

❗ Current head a4cea55 differs from pull request most recent head 4ce00cf. Consider uploading reports for the commit 4ce00cf to get more accurate results

@@             Coverage Diff             @@
##           develop    #2327      +/-   ##
===========================================
- Coverage    91.45%   91.32%   -0.13%     
===========================================
  Files          433      434       +1     
  Lines        16174    16245      +71     
===========================================
+ Hits         14792    14836      +44     
- Misses        1382     1409      +27     
Files Coverage Δ
src/onnx/padding.cpp 98.21% <100.00%> (ø)
src/onnx/parse_qlinearconv.cpp 59.15% <59.15%> (ø)

... and 1 file with indirect coverage changes

@causten causten merged commit 6816143 into develop Oct 14, 2023
15 checks passed
@causten causten deleted the missing_exports branch October 14, 2023 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip bot checks Skips the Performance and Accuracy CI tests Windows Related changes for Windows Environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants