-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change driver verify to check for fp16 and --fp16 #2334
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2334 +/- ##
========================================
Coverage 91.35% 91.35%
========================================
Files 438 438
Lines 16465 16465
========================================
Hits 15041 15041
Misses 1424 1424 |
This build is OK for merge ✅ |
🔴torchvision-inceptionv3_1: FAILED: MIGraphX is not within tolerance - check verbose output🔴slim-inceptionv4_1: FAILED: MIGraphX is not within tolerance - check verbose output🔴bert_base_cased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output🔴distilgpt2_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
… into fp16_tol_updates
@CharlieL7 can you check if the tolerances are valid, I see two models failing that were not in the past |
@causten Those tests are using the accuracy_checker script, should be unrelated to the changes in this PR. Issue originates from #2274. |
template <class T> | ||
struct value_parser<std::optional<T>> | ||
{ | ||
static T apply(const std::string& x) { return value_parser<T>::apply(x); } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this should return std::optional<T>
: static std::optional<T> apply(const std::string& x) { return value_parser<T>::apply(x); }
.
Change the tolerances based on what we find.
Use std::optional.