Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmake build type to add the properties #2339

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Fix cmake build type to add the properties #2339

merged 2 commits into from
Oct 17, 2023

Conversation

pfultz2
Copy link
Collaborator

@pfultz2 pfultz2 commented Oct 16, 2023

This was accidentally removed in #1891.

@pfultz2 pfultz2 requested a review from umangyadav October 16, 2023 17:48
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #2339 (5cc5fe7) into develop (650ba45) will not change coverage.
The diff coverage is n/a.

❗ Current head 5cc5fe7 differs from pull request most recent head 79e82de. Consider uploading reports for the commit 79e82de to get more accurate results

@@           Coverage Diff            @@
##           develop    #2339   +/-   ##
========================================
  Coverage    91.29%   91.29%           
========================================
  Files          436      436           
  Lines        16335    16335           
========================================
  Hits         14913    14913           
  Misses        1422     1422           

@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
79e82d
Rate old
650ba4
Diff Compare
torchvision-resnet50 64 2,852.55 2,855.07 -0.09%
torchvision-resnet50_fp16 64 6,481.79 6,485.89 -0.06%
torchvision-densenet121 32 2,109.68 2,099.19 0.50%
torchvision-densenet121_fp16 32 3,688.98 3,685.09 0.11%
torchvision-inceptionv3 32 1,596.70 1,598.81 -0.13%
torchvision-inceptionv3_fp16 32 2,597.13 2,594.10 0.12%
cadene-inceptionv4 16 707.87 708.32 -0.06%
cadene-resnext64x4 16 698.08 698.74 -0.09%
slim-mobilenet 64 8,354.99 8,357.32 -0.03%
slim-nasnetalarge 64 227.14 227.33 -0.08%
slim-resnet50v2 64 2,678.62 2,677.94 0.03%
bert-mrpc-onnx 8 824.84 825.54 -0.08%
bert-mrpc-tf 1 388.42 387.74 0.18%
pytorch-examples-wlang-gru 1 291.38 296.73 -1.80%
pytorch-examples-wlang-lstm 1 308.16 307.96 0.06%
torchvision-resnet50_1 1 601.59 605.56 -0.66%
torchvision-inceptionv3_1 1 341.69 337.94 1.11%
cadene-dpn92_1 1 397.15 396.52 0.16%
cadene-resnext101_1 1 328.91 329.16 -0.07%
slim-vgg16_1 1 465.24 464.46 0.17%
slim-mobilenet_1 1 2,035.06 2,075.27 -1.94%
slim-inceptionv4_1 1 217.20 217.23 -0.02%
onnx-taau-downsample 1 306.96 306.31 0.21%
dlrm-criteoterabyte 1 21.68 21.72 -0.18%
dlrm-criteoterabyte_fp16 1 40.72 40.75 -0.06%
agentmodel 1 5,804.98 5,825.40 -0.35%
unet_fp16 2 55.91 56.00 -0.17%
resnet50v1_fp16 1 938.94 935.59 0.36%
bert_base_cased_fp16 64 970.83 971.23 -0.04%
bert_large_uncased_fp16 32 305.14 305.23 -0.03%
bert_large_fp16 1 166.98 167.09 -0.07%
distilgpt2_fp16 16 1,278.56 1,278.55 0.00%

This build is OK for merge ✅

@migraphx-bot
Copy link
Collaborator


    :white_check_mark:bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

    :white_check_mark:bert-mrpc-tf: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

    :white_check_mark:torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

🔴torchvision-inceptionv3_1: FAILED: MIGraphX is not within tolerance - check verbose output


    :white_check_mark:cadene-dpn92_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:cadene-resnext101_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-vgg16_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-mobilenet_1: PASSED: MIGraphX meets tolerance

🔴slim-inceptionv4_1: FAILED: MIGraphX is not within tolerance - check verbose output


    :white_check_mark:dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

    :white_check_mark:agentmodel: PASSED: MIGraphX meets tolerance

    :white_check_mark:unet: PASSED: MIGraphX meets tolerance

    :white_check_mark:resnet50v1: PASSED: MIGraphX meets tolerance

🔴bert_base_cased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


    :white_check_mark:bert_large: PASSED: MIGraphX meets tolerance

🔴distilgpt2_fp16: FAILED: MIGraphX is not within tolerance - check verbose output

@causten causten merged commit a720061 into develop Oct 17, 2023
1 check passed
@causten causten deleted the config-types branch October 17, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants