-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmark tracing #2354
Add benchmark tracing #2354
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2354 +/- ##
========================================
Coverage 91.36% 91.36%
========================================
Files 440 440
Lines 16530 16530
========================================
Hits 15101 15101
Misses 1429 1429 |
[&](const auto& cr, const auto& solution) { | ||
if(enabled(MIGRAPHX_TRACE_BENCHMARKING{})) | ||
std::cout << "Benchmarking solution: " << solution << std::endl; | ||
if(not cr.has_value()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps keep this check earlier and only print solutions that has binary ?
Because I suspect with CK there would be a lot of solutions with no binary. it would just unnecessarily clobber terminal.
This build is OK for merge ✅ |
🔴torchvision-inceptionv3_1: FAILED: MIGraphX is not within tolerance - check verbose output🔴slim-inceptionv4_1: FAILED: MIGraphX is not within tolerance - check verbose output🔴bert_base_cased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output🔴distilgpt2_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
This adds tracing to the benchmarking. |
No description provided.