-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove int8x4 format completely #2373
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2373 +/- ##
========================================
Coverage 91.36% 91.36%
========================================
Files 440 440
Lines 16547 16547
========================================
Hits 15118 15118
Misses 1429 1429 |
pfultz2
reviewed
Oct 26, 2023
umangyadav
added
the
high priority
A PR with high priority for review and merging.
label
Oct 27, 2023
This build is not recommended to merge 🔴 |
🔴torchvision-inceptionv3_1: FAILED: MIGraphX is not within tolerance - check verbose output🔴slim-inceptionv4_1: FAILED: MIGraphX is not within tolerance - check verbose output🔴bert_base_cased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output🔴distilgpt2_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
pfultz2
approved these changes
Oct 30, 2023
TedThemistokleous
approved these changes
Oct 30, 2023
TedThemistokleous
added
the
Cleanup
Cleans up code from stale bits/warnings/previous changes for a previous feature PR
label
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Cleanup
Cleans up code from stale bits/warnings/previous changes for a previous feature PR
high priority
A PR with high priority for review and merging.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rocblas_int8x4 format is deprecated since rocm-5.6.0 and is going to get removed in 6.0.
MIOpen uses miopenint8x4 format to call into GEMM based kernels and has removed support for miopenint8x4 format recently.
This PR removes int8x4 format and related logic from codebase completely.