Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve unit test failures on navi hardware #2392

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Conversation

causten
Copy link
Collaborator

@causten causten commented Oct 31, 2023

Update rocMLIR to stop unit test FAIL: test_conv_with_strides_and_asymmetric_padding_cpu and batch_quant_dot_1
when on Navi hardware

@TedThemistokleous TedThemistokleous added bugfix Fixes a bug found in the code. dependencies Pull requests that update a dependency file labels Oct 31, 2023
@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
69a35b
Rate old
22bb77
Diff Compare
torchvision-resnet50 64 2,832.08 2,833.49 -0.05%
torchvision-resnet50_fp16 64 6,446.90 6,447.62 -0.01%
torchvision-densenet121 32 2,099.12 2,076.30 1.10%
torchvision-densenet121_fp16 32 3,661.94 3,640.02 0.60%
torchvision-inceptionv3 32 1,584.56 1,583.22 0.08%
torchvision-inceptionv3_fp16 32 2,561.13 2,542.75 0.72%
cadene-inceptionv4 16 702.92 701.41 0.21%
cadene-resnext64x4 16 691.86 690.13 0.25%
slim-mobilenet 64 8,337.14 8,306.25 0.37%
slim-nasnetalarge 64 225.52 225.89 -0.17%
slim-resnet50v2 64 2,661.39 2,664.26 -0.11%
bert-mrpc-onnx 8 820.17 813.87 0.77%
bert-mrpc-tf 1 388.15 340.27 14.07% 🔆
pytorch-examples-wlang-gru 1 303.28 156.57 93.71% 🔆
pytorch-examples-wlang-lstm 1 313.64 184.43 70.06% 🔆
torchvision-resnet50_1 1 598.24 581.46 2.89%
torchvision-inceptionv3_1 1 341.94 332.22 2.92%
cadene-dpn92_1 1 396.12 392.46 0.93%
cadene-resnext101_1 1 326.58 328.66 -0.63%
slim-vgg16_1 1 459.94 459.71 0.05%
slim-mobilenet_1 1 2,055.06 2,085.22 -1.45%
slim-inceptionv4_1 1 217.87 213.76 1.92%
onnx-taau-downsample 1 304.15 303.75 0.13%
dlrm-criteoterabyte 1 21.59 21.59 -0.00%
dlrm-criteoterabyte_fp16 1 40.64 40.64 -0.00%
agentmodel 1 5,859.81 5,875.48 -0.27%
unet_fp16 2 55.71 55.69 0.04%
resnet50v1_fp16 1 936.49 964.73 -2.93%
bert_base_cased_fp16 64 967.37 967.13 0.03%
bert_large_uncased_fp16 32 304.01 304.03 -0.01%
bert_large_fp16 1 166.84 166.36 0.29%
distilgpt2_fp16 16 1,272.35 1,273.63 -0.10%

Check results before merge 🔆

@migraphx-bot
Copy link
Collaborator


    :white_check_mark:bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

    :white_check_mark:bert-mrpc-tf: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

    :white_check_mark:torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:torchvision-inceptionv3_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:cadene-dpn92_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:cadene-resnext101_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-vgg16_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-mobilenet_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-inceptionv4_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

    :white_check_mark:agentmodel: PASSED: MIGraphX meets tolerance

    :white_check_mark:unet: PASSED: MIGraphX meets tolerance

    :white_check_mark:resnet50v1: PASSED: MIGraphX meets tolerance

🔴bert_base_cased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


    :white_check_mark:bert_large: PASSED: MIGraphX meets tolerance

🔴distilgpt2_fp16: FAILED: MIGraphX is not within tolerance - check verbose output

@causten causten merged commit 9a91cc2 into develop Nov 1, 2023
8 of 9 checks passed
@causten causten deleted the utest_fix_mlir branch November 1, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a bug found in the code. dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants