Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing <array> header file #2440

Merged
merged 2 commits into from
Nov 13, 2023
Merged

add missing <array> header file #2440

merged 2 commits into from
Nov 13, 2023

Conversation

apwojcik
Copy link
Collaborator

Fix after merging the branch develop. Required to compile on Windows.

@apwojcik apwojcik added the Windows Related changes for Windows Environments label Nov 13, 2023
@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
091519
Rate old
d05cfe
Diff Compare
torchvision-resnet50 64 2,832.10 2,829.85 0.08%
torchvision-resnet50_fp16 64 6,502.80 6,495.74 0.11%
torchvision-densenet121 32 2,092.64 2,090.34 0.11%
torchvision-densenet121_fp16 32 3,668.04 3,669.38 -0.04%
torchvision-inceptionv3 32 1,579.03 1,581.65 -0.17%
torchvision-inceptionv3_fp16 32 2,562.95 2,571.95 -0.35%
cadene-inceptionv4 16 703.28 702.72 0.08%
cadene-resnext64x4 16 692.58 692.06 0.08%
slim-mobilenet 64 8,327.20 8,320.54 0.08%
slim-nasnetalarge 64 225.56 225.50 0.03%
slim-resnet50v2 64 2,664.92 2,664.32 0.02%
bert-mrpc-onnx 8 820.26 821.33 -0.13%
bert-mrpc-tf 1 389.56 388.34 0.31%
pytorch-examples-wlang-gru 1 299.43 295.64 1.28%
pytorch-examples-wlang-lstm 1 313.87 314.69 -0.26%
torchvision-resnet50_1 1 605.91 607.37 -0.24%
torchvision-inceptionv3_1 1 338.76 341.65 -0.84%
cadene-dpn92_1 1 399.63 399.32 0.08%
cadene-resnext101_1 1 329.28 329.02 0.08%
slim-vgg16_1 1 458.47 459.83 -0.30%
slim-mobilenet_1 1 2,100.90 2,122.45 -1.02%
slim-inceptionv4_1 1 220.03 220.10 -0.03%
onnx-taau-downsample 1 305.00 303.45 0.51%
dlrm-criteoterabyte 1 21.60 21.61 -0.03%
dlrm-criteoterabyte_fp16 1 40.63 40.62 0.01%
agentmodel 1 nan nan nan%
unet_fp16 2 54.91 54.89 0.03%
resnet50v1_fp16 1 980.62 941.97 4.10% 🔆
bert_base_cased_fp16 64 967.66 967.57 0.01%
bert_large_uncased_fp16 32 304.14 304.06 0.03%
bert_large_fp16 1 166.75 166.72 0.02%
distilgpt2_fp16 16 1,271.37 1,272.55 -0.09%

This build is not recommended to merge 🔴

@migraphx-bot
Copy link
Collaborator


    :white_check_mark:bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

    :white_check_mark:bert-mrpc-tf: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

    :white_check_mark:torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:torchvision-inceptionv3_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:cadene-dpn92_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:cadene-resnext101_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-vgg16_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-mobilenet_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-inceptionv4_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

❌agentmodel: ERROR - check error outputTraceback (most recent call last):
File "/src/AMDMIGraphX/tools/accuracy/accuracy_checker.py", line 336, in
main()
File "/src/AMDMIGraphX/tools/accuracy/accuracy_checker.py", line 254, in main
pred_migx = np.array(model.run(params)[-1])
RuntimeError: /src/AMDMIGraphX/src/targets/gpu/device/include/migraphx/gpu/device/visit.hpp:140: hip_visit_views_impl: Ranks must be the same


    :white_check_mark:unet: PASSED: MIGraphX meets tolerance

    :white_check_mark:resnet50v1: PASSED: MIGraphX meets tolerance

🔴bert_base_cased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


    :white_check_mark:bert_large: PASSED: MIGraphX meets tolerance

🔴distilgpt2_fp16: FAILED: MIGraphX is not within tolerance - check verbose output

@causten causten merged commit 4ae80d9 into develop Nov 13, 2023
8 of 9 checks passed
@causten causten deleted the missing_header_file branch November 13, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Windows Related changes for Windows Environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants