-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FP8 2D forward convolution using rocMLIR #2507
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔴bert_base_cased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output🔴distilgpt2_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
…DMIGraphX into rocblas_mlir_fp8
causten
reviewed
Dec 5, 2023
TedThemistokleous
approved these changes
Dec 7, 2023
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FP8 convolutions that uses rocMLIR.
Uses rocMLIR from SHA : 5085343bca363109ae9ebabb7ca2b65c52bc861cROCm/rocMLIR#1336regular
convolution
takes in both inputs as FP8 and generates FP8 output. Internally on hardware it will do accumulation in Fp32 but final result is converted back to fp8 using downcasting.quant_convolution
takes in both inputs as fp8 and generates FP32 output. This version can utilize QDQ quantization scheme to use scales to downcast FP32 output to fp8.rocMLIR fp8 convolution are limited to 2d forward convolutions only. Therefore only have added tests for those.
3D convolutions, 1D convolution, backwards convolution (transposed convolutions) "tests" therefore are not enabled.
convert
fusion withmlir-convolution
is not compiling on non-MI300 hardware therefore disabled it.For now i've kept both versions of convolutions (quant and regular). In future if there is no use for regular fp8 convolution then it can be removed.
Testing :
make check
passes on MI300.depends on #2473