Add warnings for FP8 onnx #2531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umangyadav
added
FP8
|
@pfultz2 can't find your username for some reason in reviewers list. Therefore pinging here manually. |
TedThemistokleous
approved these changes
Dec 7, 2023
TedThemistokleous
approved these changes
Dec 7, 2023
CharlieL7
approved these changes
Dec 7, 2023
|
You could put this warning in the compile step, that way it warns whether it was created manually, onnx or tensorflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to put some warnings.
Can't find a better place other than parser to put these warnings. Ideally warnings should come from API side.
This would work for both C/C++ and Python.
But this wouldn't work if users were to create python or C program themselves. I assume it is not a usecase other than for testing purpose.