Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rocMLIR to tip of release branch #2539

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Conversation

krzysz00
Copy link
Contributor

@krzysz00 krzysz00 commented Dec 8, 2023

This bumps the rocMLIR commit to the tip of our 6.1 release branch, pulling in the fixes for floating-point quantization as well as our merge of amd-mainline-open.

This should be merged quickly and I see no reason for it to change much of anything.

This bumps the rocMLIR commit to the tip of our 6.1 release branch,
pulling in the fixes for floating-point quantization as well as our
merge of amd-mainline-open.

This should be merged quickly and I see no reason for it to change
much of anything.
@umangyadav umangyadav mentioned this pull request Dec 8, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@7e53592). Click here to learn what that means.

❗ Current head b629a89 differs from pull request most recent head c27d544. Consider uploading reports for the commit c27d544 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2539   +/-   ##
==========================================
  Coverage           ?   91.50%           
==========================================
  Files              ?      453           
  Lines              ?    17183           
  Branches           ?        0           
==========================================
  Hits               ?    15723           
  Misses             ?     1460           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
c27d54
Rate old
7e5359
Diff Compare
torchvision-resnet50 64 2,833.40 2,835.01 -0.06%
torchvision-resnet50_fp16 64 6,506.45 6,502.27 0.06%
torchvision-densenet121 32 2,091.68 2,095.15 -0.17%
torchvision-densenet121_fp16 32 3,663.59 3,666.68 -0.08%
torchvision-inceptionv3 32 1,598.23 1,597.66 0.04%
torchvision-inceptionv3_fp16 32 2,559.47 2,557.91 0.06%
cadene-inceptionv4 16 722.20 722.14 0.01%
cadene-resnext64x4 16 691.51 692.42 -0.13%
slim-mobilenet 64 8,346.21 8,340.53 0.07%
slim-nasnetalarge 64 230.54 nan nan%
slim-resnet50v2 64 2,662.65 2,665.84 -0.12%
bert-mrpc-onnx 8 823.29 823.89 -0.07%
bert-mrpc-tf 1 390.29 389.19 0.28%
pytorch-examples-wlang-gru 1 301.74 300.04 0.57%
pytorch-examples-wlang-lstm 1 315.41 310.27 1.65%
torchvision-resnet50_1 1 604.07 605.92 -0.31%
torchvision-inceptionv3_1 1 345.17 343.11 0.60%
cadene-dpn92_1 1 403.35 401.62 0.43%
cadene-resnext101_1 1 328.30 327.69 0.18%
slim-vgg16_1 1 458.73 460.40 -0.36%
slim-mobilenet_1 1 2,093.04 2,070.91 1.07%
slim-inceptionv4_1 1 213.02 213.25 -0.11%
onnx-taau-downsample 1 305.07 305.23 -0.05%
dlrm-criteoterabyte 1 21.59 21.60 -0.05%
dlrm-criteoterabyte_fp16 1 40.63 40.64 -0.02%
agentmodel 1 5,928.84 5,973.93 -0.75%
unet_fp16 2 54.76 54.69 0.13%
resnet50v1_fp16 1 921.01 939.01 -1.92%
bert_base_cased_fp16 64 903.32 903.48 -0.02%
bert_large_uncased_fp16 32 285.67 285.65 0.01%
bert_large_fp16 1 166.75 166.71 0.02%
distilgpt2_fp16 16 1,280.77 1,281.56 -0.06%

This build is not recommended to merge 🔴

@migraphx-bot
Copy link
Collaborator


     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

     ✅ bert-mrpc-tf: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

     ✅ torchvision-inceptionv3_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-dpn92_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-resnext101_1: PASSED: MIGraphX meets tolerance

     ✅ slim-vgg16_1: PASSED: MIGraphX meets tolerance

     ✅ slim-mobilenet_1: PASSED: MIGraphX meets tolerance

     ✅ slim-inceptionv4_1: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

     ✅ unet: PASSED: MIGraphX meets tolerance

     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

     ✅ bert_base_cased_fp16: PASSED: MIGraphX meets tolerance

     ✅ bert_large_uncased_fp16: PASSED: MIGraphX meets tolerance

     ✅ bert_large: PASSED: MIGraphX meets tolerance

🔴distilgpt2_fp16: FAILED: MIGraphX is not within tolerance - check verbose output

@causten causten merged commit 9d2003a into develop Dec 9, 2023
34 of 37 checks passed
@causten causten deleted the mlir-move-to-release branch December 9, 2023 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants