refactoring quantization passes #2544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivadbhavsar
approved these changes
Dec 12, 2023
pfultz2
reviewed
Dec 12, 2023
| @@ -41,7 +41,7 @@ struct module; | |||
| */ | |||
| struct MIGRAPHX_EXPORT capture_arguments_pass | |||
| { | |||
| std::vector<std::string> ins_names = {"dot", "convolution"}; | |||
| std::set<std::string> ins_names = {"dot", "convolution"}; | |||
There was a problem hiding this comment.
Do you think unordered_set would be better?
There was a problem hiding this comment.
yes for sure. I can make change
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #2544 +/- ##
========================================
Coverage 91.41% 91.42%
========================================
Files 452 452
Lines 17153 17148 -5
========================================
- Hits 15681 15678 -3
+ Misses 1472 1470 -2 ☔ View full report in Codecov by Sentry. |
pfultz2
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quantize_8bits_passwasn't really usingins_namesfield. Removed it.using
std::setfor keeping names of the operators to be quantized instead ofstd::vectorfor easy lookup.